Skip to content

Move headers into transport and g4integration layout#612

Merged
SeverinDiederichs merged 3 commits intoapt-sim:masterfrom
SeverinDiederichs:header_layout_forwarders
May 5, 2026
Merged

Move headers into transport and g4integration layout#612
SeverinDiederichs merged 3 commits intoapt-sim:masterfrom
SeverinDiederichs:header_layout_forwarders

Conversation

@SeverinDiederichs
Copy link
Copy Markdown
Collaborator

@SeverinDiederichs SeverinDiederichs commented May 4, 2026

Following #609, this PR reorganizes the headers into the transport and g4integration libraries.

After the sources have been moved in #610, this moves the headers.

To allow for a compatibility period with users, the publicly-used headers of the AdePTConfiguration, AdePTTrackingManager, and the physics constructors, are kept as a forwarding layer to the new design.

They will be deleted as soon as LHCb, ATLAS, CMS, and dd4hep are moved to the new design.

In the restructure, copcore was dissolved and the components moved to the correct part. Note that the copcore namespace was kept, this should be cleaned later.

The documentation was updated: The integration of AdePT is better described and it uses the new path for the headers.

@SeverinDiederichs SeverinDiederichs added the cleaning improves code clarity, readability or other label May 4, 2026
@SeverinDiederichs
Copy link
Copy Markdown
Collaborator Author

/run-test

@phsft-bot
Copy link
Copy Markdown

Can one of the admins verify this patch?

@SeverinDiederichs SeverinDiederichs requested a review from agheata May 4, 2026 15:38
@SeverinDiederichs SeverinDiederichs force-pushed the header_layout_forwarders branch from 0e087e5 to 9f9de0b Compare May 4, 2026 16:00
@SeverinDiederichs
Copy link
Copy Markdown
Collaborator Author

/run-test

@SeverinDiederichs
Copy link
Copy Markdown
Collaborator Author

/run-test

Copy link
Copy Markdown
Contributor

@agheata agheata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No pending issues, thanks for the big restructuring step!

@SeverinDiederichs SeverinDiederichs merged commit 034ebee into apt-sim:master May 5, 2026
6 checks passed
@SeverinDiederichs SeverinDiederichs deleted the header_layout_forwarders branch May 5, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleaning improves code clarity, readability or other

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants