Split AsyncAdePTTransportStruct headers into topical headers#614
Merged
SeverinDiederichs merged 3 commits intoapt-sim:masterfrom May 5, 2026
Merged
Conversation
Collaborator
Author
|
/run-test |
7 tasks
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split the old
AsyncAdePTTransportStruct.*headers into smaller topical headers.This is intended as a cleanup only: the transport data structures are grouped by responsibility, while runtime behavior should remain unchanged. The split makes the async transport state easier to navigate and reduces the amount of unrelated CUDA-side state pulled in through one broad header.
The following files were removed / renamed
include/AdePT/transport/AsyncAdePTTransportStruct.cuhinclude/AdePT/transport/AsyncAdePTTransportStruct.hhinto
include/AdePT/transport/queues/ParticleManager.cuhinclude/AdePT/transport/queues/ParticleQueues.cuhinclude/AdePT/transport/state/DeviceGlobals.cuhinclude/AdePT/transport/state/GPUState.cuhinclude/AdePT/transport/state/TransportStats.hhFurther cleanup:
As part of the split, avoid defining reusable symbols directly in topical headers:
gMagneticFieldis now declared inDeviceGlobals.cuhand defined once beside the other device globals inAsyncAdePTTransport.cuh.GPUstateDeleter::operator()is now defined once insrc/transport/AsyncAdePTTransport.cu.This keeps the new headers safer to reuse from additional translation units.