refactor: improve list command performance#367
Merged
Conversation
neurosnap
commented
Feb 3, 2025
lib/aptible/cli/agent.rb
Outdated
| Aptible::Resource.configure { |conf| conf.user_agent = version_string } | ||
| Aptible::Resource.configure do |conf| | ||
| conf.user_agent = version_string | ||
| # conf.logger.tap { |l| l.level = Logger::INFO } |
Contributor
Author
There was a problem hiding this comment.
This is nice for debugging and I kind of want to keep it in the code so it's discoverable.
UserNotFound
requested changes
Feb 4, 2025
Contributor
Author
|
Nice catch! I missed a couple of account checks, should be fixed now. |
UserNotFound
previously approved these changes
Feb 7, 2025
Member
UserNotFound
left a comment
There was a problem hiding this comment.
LGTM! This is much easier than the mess I got into looking at modifying aptible-resource or whatever...
One nit would be that if you intend for end-users to provide debug logging via the commented out conf.logger.tap { |l| l.level = Logger::INFO }, we should just make it toggled via an ENV. If it's just for us, code/comment is totally fine as is.
Contributor
Author
|
Added an environment variable |
UserNotFound
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

https://app.shortcut.com/aptible/story/30651/cli-performance-for-list-commands
environment:list
before
after
apps
before
after
db:list
before
after