Skip to content

Improve/documentation#1359

Merged
neolynx merged 38 commits intomasterfrom
improve/documentation
Dec 11, 2024
Merged

Improve/documentation#1359
neolynx merged 38 commits intomasterfrom
improve/documentation

Conversation

@neolynx
Copy link
Copy Markdown
Member

@neolynx neolynx commented Oct 4, 2024

Fixes: #181

Description of the Change

Document all APIs with swagger

Replace and automate the API documentation on https://www.aptly.info/doc/api document API calls with swagger.

Run swagger

make docker-serve

See Swagger doc: http://localhost:3142/docs

Note: as the dev server has live reload, changes to the code will be recompiled, then the page can be reloaded.

Document aptly.conf

Found that aptly uses github.com/DisposaBoy/JsonConfigReader already, turns out it supports comments in json,
so we can have a inline documented config file :)

Checklist

  • swagger documentation updated
  • pipeline to publish CI or Release doc somewhere (gh-pages / aptly.info?)

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 10 lines in your changes missing coverage. Please review.

Project coverage is 75.02%. Comparing base (f9ae9b3) to head (e319f3c).
Report is 39 commits behind head on master.

Files with missing lines Patch % Lines
utils/config.go 70.00% 2 Missing and 1 partial ⚠️
api/repos.go 50.00% 2 Missing ⚠️
api/router.go 83.33% 1 Missing and 1 partial ⚠️
context/context.go 75.00% 1 Missing and 1 partial ⚠️
main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1359      +/-   ##
==========================================
- Coverage   75.12%   75.02%   -0.10%     
==========================================
  Files         157      157              
  Lines       18172    18146      -26     
==========================================
- Hits        13651    13614      -37     
- Misses       3404     3409       +5     
- Partials     1117     1123       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neolynx neolynx self-assigned this Oct 4, 2024
@neolynx neolynx added the help wanted ! Please help getting this PR merged :-) label Oct 4, 2024
@neolynx neolynx force-pushed the improve/documentation branch from 80c1b51 to 5156aa0 Compare October 4, 2024 14:13
@neolynx neolynx requested a review from a team October 4, 2024 14:41
@neolynx neolynx force-pushed the improve/documentation branch from df8a358 to 236e0d6 Compare October 5, 2024 16:24
@neolynx neolynx added the WIP label Oct 5, 2024
@neolynx neolynx force-pushed the improve/documentation branch from 236e0d6 to 092e088 Compare October 5, 2024 17:11
@neolynx neolynx force-pushed the improve/documentation branch 5 times, most recently from f7903cb to af56e15 Compare October 9, 2024 18:13
@neolynx neolynx force-pushed the improve/documentation branch from af56e15 to e673378 Compare October 15, 2024 11:59
@neolynx neolynx force-pushed the improve/documentation branch from e673378 to cafd7d0 Compare October 22, 2024 18:47
@neolynx neolynx force-pushed the improve/documentation branch 3 times, most recently from 70e13f6 to 2567dba Compare November 8, 2024 15:27
@iofq
Copy link
Copy Markdown
Contributor

iofq commented Nov 17, 2024

Working on filling in TODO stubs, starting with api/task

@neolynx neolynx force-pushed the improve/documentation branch from 2567dba to c8cf59c Compare November 17, 2024 17:16
@neolynx
Copy link
Copy Markdown
Member Author

neolynx commented Nov 17, 2024

Working on filling in TODO stubs, starting with api/task

thank you so much in advance !

@neolynx
Copy link
Copy Markdown
Member Author

neolynx commented Nov 17, 2024

I pushed a fix for lint, please git pull --rebase :-)

@iofq iofq force-pushed the improve/documentation branch from 85a9d73 to c7b7567 Compare November 19, 2024 02:01
@iofq
Copy link
Copy Markdown
Contributor

iofq commented Nov 19, 2024

Believe I took care of all the API stubs

@neolynx neolynx force-pushed the improve/documentation branch from ac76097 to 1f3c9a8 Compare November 28, 2024 12:44
@neolynx neolynx added needs review Ready for review & merge and removed WIP help wanted ! Please help getting this PR merged :-) labels Nov 28, 2024
@neolynx neolynx force-pushed the improve/documentation branch from 1f3c9a8 to 4052973 Compare November 28, 2024 12:53
@neolynx neolynx force-pushed the improve/documentation branch from 067e2a1 to e319f3c Compare December 11, 2024 10:20
@neolynx neolynx merged commit 465312b into master Dec 11, 2024
@neolynx neolynx deleted the improve/documentation branch December 11, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs approval needs review Ready for review & merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Usage output reads like shell pipe chain (without need to)

4 participants