Skip to content

Expose the context outside of the cmd package.#630

Merged
smira merged 1 commit intoaptly-dev:masterfrom
skyscrapers:expose-context
Sep 22, 2017
Merged

Expose the context outside of the cmd package.#630
smira merged 1 commit intoaptly-dev:masterfrom
skyscrapers:expose-context

Conversation

@ringods
Copy link
Copy Markdown
Contributor

@ringods ringods commented Sep 5, 2017

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

Skyscrapers wants to contribute back what we use from the community. We are a heavy user of Concourse. Concourse supports monitoring changes in different artifacts by way of resource types. We are contributing a new resource type to monitor the release of new versions of a package and trigger builds when that happens:

https://github.com/skyscrapers/apt-package-resource

We are still in development for this resource, but so far I had to make one change to the aptly code base to support is in reusing the code: have access to the command context.

This resource type is my first Go contribution which means that also this PR is possibly not the way you should do things in Go. I'm open to learn how to do it better then.

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

Copy link
Copy Markdown
Contributor

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you please rebase your changes against latest master, it should build fine now.

@smira smira added the 1.2.0 label Sep 18, 2017
@ringods
Copy link
Copy Markdown
Contributor Author

ringods commented Sep 22, 2017

@smira rebased. But I see that that last travis build on master failed, so the build results from my PR won't be any better. ;-)

https://travis-ci.org/smira/aptly/builds/276999193

@smira smira merged commit 325d391 into aptly-dev:master Sep 22, 2017
@smira
Copy link
Copy Markdown
Contributor

smira commented Sep 22, 2017

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants