Expose the context outside of the cmd package.#630
Merged
smira merged 1 commit intoaptly-dev:masterfrom Sep 22, 2017
skyscrapers:expose-context
Merged
Expose the context outside of the cmd package.#630smira merged 1 commit intoaptly-dev:masterfrom skyscrapers:expose-context
smira merged 1 commit intoaptly-dev:masterfrom
skyscrapers:expose-context
Conversation
smira
approved these changes
Sep 18, 2017
Contributor
smira
left a comment
There was a problem hiding this comment.
LGTM, could you please rebase your changes against latest master, it should build fine now.
Contributor
Author
|
@smira rebased. But I see that that last travis build on |
Contributor
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
All new code should be covered with tests, documentation should be updated. CI should pass.
Description of the Change
Skyscrapers wants to contribute back what we use from the community. We are a heavy user of Concourse. Concourse supports monitoring changes in different artifacts by way of resource types. We are contributing a new resource type to monitor the release of new versions of a package and trigger builds when that happens:
https://github.com/skyscrapers/apt-package-resource
We are still in development for this resource, but so far I had to make one change to the
aptlycode base to support is in reusing the code: have access to the command context.This resource type is my first Go contribution which means that also this PR is possibly not the way you should do things in Go. I'm open to learn how to do it better then.
Checklist
AUTHORS