chore: update to arrow-58

[jpopesculian]

Summary by CodeRabbit

• Dependencies

  • Upgraded parquet and arrow crate dependencies (parquet and arrow from v56 to v58; serde_arrow from 0.13.5 to 0.14).

• Refactor

  • Updated internal code for compatibility with upgraded parquet library versions.

[coderabbitai]

Warning

Rate limit exceeded

@jpopesculian has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 50 minutes and 52 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1b187be5-cb12-4073-8d0e-0a9dba6bfcb1

📥 Commits

Reviewing files that changed from the base of the PR and between 6fbbb9b and cb88b59.

⛔ Files ignored due to path filters (1)

• Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (7)

• Cargo.toml
• data-utils/Cargo.toml
• data-utils/src/infer.rs
• data-utils/src/wasm/write.rs
• data-utils/src/write.rs
• src/commands/dataset/convert.rs
• src/commands/dataset/upload.rs

📝 Walkthrough

Walkthrough

This pull request upgrades Arrow/Parquet crate versions from 56 to 58 and serde_arrow from 0.13.5 to 0.14. The codebase is then updated to use new parquet metadata types and accessor patterns introduced by these dependency upgrades.

Changes

Cohort / File(s)	Summary
Dependency Version Upgrades Cargo.toml, data-utils/Cargo.toml	Bumped parquet from 56 to 58, arrow and arrow-ipc from 56 to 58, and serde_arrow from 0.13.5 to 0.14 with corresponding feature flag update from arrow-56 to arrow-58.
Parquet Metadata Type Migrations data-utils/src/write.rs, data-utils/src/wasm/write.rs, src/commands/dataset/convert.rs	Migrated from parquet::format::* types (FileMetaData, SortingColumn) to parquet::file::metadata::* equivalents and updated writer property handling to use set_max_row_group_row_count(Some(...)) instead of set_max_row_group_size.
Parquet Row Count Access Updates data-utils/src/write.rs, src/commands/dataset/convert.rs, src/commands/dataset/upload.rs	Changed row count access from direct field access (meta.num_rows) to accessor method calls (meta.file_metadata().num_rows()).
Serde Arrow Error API Update data-utils/src/infer.rs	Updated error construction in field_to_serde_arrow_overwrite from serde_arrow::Error::custom(...) to serde_arrow::Error::new(serde_arrow::ErrorKind::Custom, ...).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Our Arrow soars from fifty-six to fifty-eight,
Metadata types in new homes migrate,
Accessors bloom where fields once stood,
Parquet flows stronger—all is good!
Dependencies dance, the codebase sings. 🎵

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'chore: update to arrow-58' accurately summarizes the main objective of the pull request, which is to upgrade Arrow and related crate dependencies from version 56 to 58 across multiple files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jpop/arrow-58

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

src/commands/dataset/convert.rs (1)

100-108: Optional: use Self in the From impl body.

Inside impl From<SortingColumn> for parquet::file::metadata::SortingColumn, you can drop the fully-qualified path on Line 102 and use Self { ... } for symmetry with the corresponding wasm impl in data-utils/src/wasm/write.rs (Line 359-367).

♻️ Proposed cleanup

 impl From<SortingColumn> for parquet::file::metadata::SortingColumn {
     fn from(value: SortingColumn) -> Self {
-        parquet::file::metadata::SortingColumn {
+        Self {
             column_idx: value.column_idx,
             descending: value.descending,
             nulls_first: value.nulls_first,
         }
     }
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/commands/dataset/convert.rs` around lines 100 - 108, In the impl
From<SortingColumn> for parquet::file::metadata::SortingColumn, replace the
explicit fully-qualified constructor parquet::file::metadata::SortingColumn {
... } inside fn from with Self { column_idx: value.column_idx, descending:
value.descending, nulls_first: value.nulls_first } so the impl uses Self for
symmetry with the wasm variant and reduces verbosity; keep the impl signature
and field mappings unchanged.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/commands/dataset/convert.rs`:
- Around line 100-108: In the impl From<SortingColumn> for
parquet::file::metadata::SortingColumn, replace the explicit fully-qualified
constructor parquet::file::metadata::SortingColumn { ... } inside fn from with
Self { column_idx: value.column_idx, descending: value.descending, nulls_first:
value.nulls_first } so the impl uses Self for symmetry with the wasm variant and
reduces verbosity; keep the impl signature and field mappings unchanged.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a51e7725-cd1c-451f-8224-d54ec6003030

📥 Commits

Reviewing files that changed from the base of the PR and between fe7c4e1 and 6fbbb9b.

⛔ Files ignored due to path filters (1)

• Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (7)

• Cargo.toml
• data-utils/Cargo.toml
• data-utils/src/infer.rs
• data-utils/src/wasm/write.rs
• data-utils/src/write.rs
• src/commands/dataset/convert.rs
• src/commands/dataset/upload.rs