fix: queue manual refresh while busy#12
Conversation
aqua5230
left a comment
There was a problem hiding this comment.
Behavior change is solid and the tests are real. One blocker against current main: _applyRefreshResult_ in v0.11.6
(commit ba66688) now also writes self.codex_model, and the ivar declaration on AppDelegate added codex_model.
Could you rebase onto main and make sure the queued-refresh finally block preserves both self.codex_model = result.get("codex_model", "unknown") and the existing language-injection step? After rebase this should be straight to
merge.
702cab6 to
4dbf7df
Compare
|
Updated, thanks. I rebased onto current main and resolved the refresh queue patch around the v0.11.6 state update path. The queued-refresh finally block now preserves both self.codex_model = result.get("codex_model", "unknown") and the existing language injection step before clearing the busy flag and draining one queued refresh.\n\nValidation run locally:\n- .venv/bin/python -m pytest tests/test_menubar.py\n- .venv/bin/python -m ruff check menubar.py tests/test_menubar.py\n- .venv/bin/python -m mypy . |
- fix(badge): clear update hint immediately after upgrade past cached latest - fix(reporter): bucket Codex usage by token_count deltas (#11, @ericweichun) - fix(reports): tie All Time reports to project range selector (#15, @ericweichun) - fix(refresh): queue manual refresh while busy (#12, @ericweichun) - docs(setup): make setup guidance agent-neutral (#16, @ericweichun) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Summary
Test plan
Notes for reviewer
This only changes explicit manual refresh behavior. Timer and FSEvents refresh calls still coalesce while a refresh is in flight.