Aqua CloudSploit Plugin Assessment #271
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Aqua CloudSploit Plugin Assessment
matthewdfuller
suggested changes
Aug 13, 2020
Contributor
matthewdfuller
left a comment
matthewdfuller
left a comment
There was a problem hiding this comment.
Looks good overall, but one small fix
Comment on lines
46
to
55
| if (sg.IpPermissions.length || | ||
| sg.IpPermissionsEgress.length) { | ||
| helpers.addResult(results, 2, | ||
| sg.GroupName + 'security group has ' + (sg.IpPermissions.length || '0') + ' inbound and ' + (sg.IpPermissionsEgress.length || '0') + ' outbound rules', | ||
| region, resource); | ||
| } else { | ||
| helpers.addResult(results, 0, | ||
| 'Default security group does not have inbound or outbound rules', | ||
| region, resource); | ||
| } |
Contributor
There was a problem hiding this comment.
This is a good additional check, but for now we just want to flag the group, regardless of whether it has any rules or not. Can you modify this section to remove the extra if/else check?
Author
There was a problem hiding this comment.
Okay, will remove this additional check.
Removed if/else condition to check length of rules.
Contributor
|
Thanks for submitting @iamasimforever - closing this now that we are moving forward with other plugins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aqua CloudSploit Plugin Assessment: EC2 LaunchWizard Security Groups.