disable timeutils test to prevent depending on mgo#85
Merged
araddon merged 1 commit intoaraddon:masterfrom May 10, 2019
egonelbre:remove-mgo
Merged
disable timeutils test to prevent depending on mgo#85araddon merged 1 commit intoaraddon:masterfrom egonelbre:remove-mgo
araddon merged 1 commit intoaraddon:masterfrom
egonelbre:remove-mgo
Conversation
8 tasks
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 885 885
=====================================
Hits 885 885Continue to review full report at Codecov.
|
Owner
|
awesome, ty |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
timeutilsbenchmark ends up pulling inmgoas a dependency to other projects. Comment out the test so it's not a strict requirement.Unfortunately, didn't find a nice way to avoid creating a dependency and still make benchmarks work with a special flag.