Update OnPolicyAlgorithmJax & PPO to support custom rollout_buffer_class#90
Merged
Merged
Conversation
16 tasks
araffin
reviewed
May 8, 2026
|
|
||
| self.rollout_buffer = RolloutBuffer( | ||
| if self.rollout_buffer_class is None: | ||
| if isinstance(self.observation_space, spaces.Dict): |
Owner
There was a problem hiding this comment.
is dict obs space supported for PPO?
if not, maybe put an assert (and add a small test to check it fails)
Contributor
Author
There was a problem hiding this comment.
MultiInputPolicy indeed haven't been implemented for PPO yet. I added the assertion and new test case for it. Although @araffin maybe it's a bit better to raise NotImplementedError here and in OffPolicyAlgorithmJax._setup_model()?
araffin
reviewed
May 8, 2026
Owner
araffin
left a comment
There was a problem hiding this comment.
thanks for the PR, overall LGTM =) just a small comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #89
Just a small add to support
rollout_buffer_classandrollout_buffer_kwargsarguments in constructor ofPPOandOnPolicyAlgorithmJax, like in Stable Baselines3.Motivation and Context
Types of changes
Checklist:
make format(required)make check-codestyleandmake lint(required)make pytestandmake typeboth pass. (required)make doc(required)Note: You can run most of the checks using
make commit-checks.Note: we are using a maximum length of 127 characters per line