fix: Include sub-plugins when fetching plugins on the member details page#1047
Merged
fix: Include sub-plugins when fetching plugins on the member details page#1047
Conversation
…page Signed-off-by: Milos Dzepina <milos@aragon.org>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes DAO member details rendering for DAOs using Staged Proposal Pipeline (SPP) by ensuring sub-plugins are included when resolving the “body” plugin metadata on the client.
Changes:
- Enable
includeSubPlugins: truein theuseDaoPluginscall on the member details client page. - Add
.patchesto.gitignore. - Add a Changesets patch entry for the release notes/versioning.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/modules/governance/pages/daoMemberDetailsPage/daoMemberDetailsPageClient.tsx |
Ensures sub-plugins are included so the correct body plugin can be resolved under SPP. |
.gitignore |
Ignores a .patches directory (needs confirmation it shouldn’t be committed). |
.changeset/member-details-include-sub-plugins.md |
Adds a patch changeset documenting the fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🚀 Preview Deployment: View Here |
|
E2E Smoke Results
|
evanaronson
approved these changes
Mar 21, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
includeSubPlugins: trueto theuseDaoPluginscall indaoMemberDetailsPageClient. Without this flag, SPP sub-plugins (used for vote submission, member details, and version info) were not included, causing the member details page to not resolve the correct body plugin when the DAO uses a Staged Proposal Pipeline.Type of Change
Developer Checklist:
Review Checklist: