Conversation
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
|
🚀 Preview Deployment: View Here |
…ons-from-json-upload
|
E2E Smoke Results
|
thekidnamedkd
previously approved these changes
Apr 2, 2026
Contributor
thekidnamedkd
left a comment
There was a problem hiding this comment.
Looks good!✨ I would maybe just keep the var names the same as much as possible and not past tense where possible
Contributor
Author
yeah, makes sense, I'll update |
Signed-off-by: Milos Dzepina <milos@aragon.org>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a crash that occurred when removing items from the middle of an uploaded JSON action list (or similar watched field arrays). The root cause was a stale-data race between
useWatchanduseFieldArray: immediately afterremove(),useWatchstill returns the old (longer) array whilefieldshas already been updated, causing the merge map to override fieldArray items with wrong items from watched list, while id/key of items is kept the same.Fix: Before merging
fieldsandwatchFieldArray, check that their lengths match. If they don't (stale frame), skip the watch data for that render and preserve thefield.idfrom the source-of-truthuseFieldArray. Applied to:CreateProposalFormActions(JSON upload actions)GovernanceStageBodiesField(governance stage bodies)TokenSetupMembershipCreateToken(token member list)Resolves APP-593.
Type of Change
Developer Checklist:
Review Checklist: