Skip to content

chore(APP-581): Revise release workflow#1080

Merged
tyhonchik merged 2 commits into
mainfrom
app-581-revise-hotfix-workflow
Apr 10, 2026
Merged

chore(APP-581): Revise release workflow#1080
tyhonchik merged 2 commits into
mainfrom
app-581-revise-hotfix-workflow

Conversation

@tyhonchik
Copy link
Copy Markdown
Contributor

Description

  • Finalize release on PR merge (not label+approval)
  • Tag tested commit SHA (branch HEAD, not post-merge)
  • Consistent Slack threading across staging, production, and release PR flows
  • Hotfix: remove changeset/version bump/PR-to-main; add tag + full staging test run
  • Add BV tests to release PR flow (non-blocking)

Type of Change

  • Major: Breaking change (change that would cause existing functionality to not work as expected)
  • Minor: Feature (non-breaking change which adds new functionality)
  • Patch: Enhancement (non-breaking change to an existing feature)
  • Patch: Bug fix (non-breaking change which fixes an issue)

Developer Checklist:

  • Manually smoke tested the functionality in a preview or locally
  • Confirmed there are no new warnings or errors in the browser console
  • (For User Stories only) Double-checked that all Acceptance Criteria are satisfied
  • Confirmed there are no new warnings on automated tests
  • Merged and published any dependent changes in downstream modules
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the Files Changed in Github’s UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

Review Checklist:

  • (For User Stories only) Tested in a preview or locally that all Acceptance Criteria are satisfied
  • Confirmed that changes follow the code style guidelines of this project

@tyhonchik tyhonchik requested a review from a team as a code owner April 7, 2026 08:04
@linear
Copy link
Copy Markdown

linear Bot commented Apr 7, 2026

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2026

🚀 Preview Deployment: View Here

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2026

E2E results (preview)

Smoke

Base URL https://app-next-1s2k8bcyp-aragon-app.vercel.app
Suite smoke
Playwright result ❌ failed
Summary 66 passed, 7 failed, 7 skipped
GitHub job ✅ completed

View run #4009

@tyhonchik tyhonchik force-pushed the app-581-revise-hotfix-workflow branch from 7b23fd7 to 1ffb51c Compare April 7, 2026 10:03
@tyhonchik tyhonchik force-pushed the app-581-revise-hotfix-workflow branch from 1ffb51c to f634943 Compare April 7, 2026 10:10
@thekidnamedkd thekidnamedkd changed the title chore(APP-581): revise release workflow chore(APP-581): Revise release workflow Apr 8, 2026
Copy link
Copy Markdown
Contributor

@thekidnamedkd thekidnamedkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments! Looks slick 💪

Comment thread .github/workflows/hotfix-start.yml Outdated
Comment thread .github/workflows/app-staging.yml
- Finalize release on PR merge (not label+approval)
- Tag tested commit SHA (branch HEAD, not post-merge)
- Consistent Slack threading across staging, production, and release PR flows
- Hotfix: remove changeset/version bump/PR-to-main; add tag + full staging test run
- Add BV tests to release PR flow (non-blocking)
@tyhonchik tyhonchik force-pushed the app-581-revise-hotfix-workflow branch from 20c5f63 to f5aa83b Compare April 9, 2026 14:48
@tyhonchik tyhonchik requested a review from thekidnamedkd April 9, 2026 14:58
Copy link
Copy Markdown
Contributor

@thekidnamedkd thekidnamedkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@tyhonchik tyhonchik merged commit 16e86b5 into main Apr 10, 2026
17 checks passed
@tyhonchik tyhonchik deleted the app-581-revise-hotfix-workflow branch April 10, 2026 11:08
This was referenced Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants