feat(APP-591): Add featured delegates functionality to DAO dashboard and members page#1083
Merged
Merged
Conversation
tyhonchik
commented
Apr 8, 2026
|
🚀 Preview Deployment: View Here |
|
E2E results (preview) Smoke
|
tyhonchik
force-pushed
the
app-591-citrea-featured-delegates
branch
from
f66d114 to
a36df7f
Compare
tyhonchik
force-pushed
the
app-591-citrea-featured-delegates
branch
from
a36df7f to
93bf45c
Compare
tyhonchik
force-pushed
the
app-591-citrea-featured-delegates
branch
from
93bf45c to
aa6bcd7
Compare
milosh86
reviewed
Apr 9, 2026
Contributor
milosh86
left a comment
milosh86
left a comment
There was a problem hiding this comment.
Nice work, tested the preview too and it looks good 👍
Just one minor question to understand some logic and one place where linked accounts param might be missing.
milosh86
reviewed
Apr 9, 2026
Contributor
thekidnamedkd
left a comment
thekidnamedkd
left a comment
There was a problem hiding this comment.
Very nice! A couple comments.
| const daoId = await daoUtils.resolveDaoId(daoPageParams); | ||
| const [daoId, featuredDelegates] = await Promise.all([ | ||
| daoUtils.resolveDaoId(daoPageParams), | ||
| cmsService.getFeaturedDelegates(), |
Contributor
There was a problem hiding this comment.
should we cache this with Tanstack?
Contributor
Author
There was a problem hiding this comment.
This runs in a Next.js server component, so cmsService handles caching via force-cache + revalidate: 600 at the fetch level
…and members page - Introduced a new feature to display featured delegates in the DAO dashboard and members page. - Updated translations for "Featured delegates" in the localization files. - Enhanced the DashboardOnboarded component to handle featured delegates and adjust the members tab accordingly. - Integrated a new FeaturedDelegatesList component to render the list of featured delegates. - Modified the DAO members page to fetch and display featured delegates from the CMS. - Updated related components and hooks to support the new featured delegates functionality.
tyhonchik
force-pushed
the
app-591-citrea-featured-delegates
branch
from
aa6bcd7 to
f508139
Compare
milosh86
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test
For testing use this DAO
dao/ethereum-sepolia/0xEB4813f79E18bbd62F9222CC98F5049B872F5c04Type of Change
Developer Checklist:
Review Checklist: