fix(APP-592): Correctly sort bodies plugin bodies by grouping #1091
Merged
Conversation
…-order-of-bodies-in-member-list
|
🚀 Preview Deployment: View Here |
|
E2E results (preview) Smoke
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The plugin sort in
useDaoPluginswas usingisSubPluginalongsidedaoAddressto determine root-DAO membership. This conflated SPP parent-child plugin relationships with linked account (DAO-to-DAO) relationships, causing tokenVoting sub-plugins on the root DAO to sort after standalone multisig plugins.For example on Cryptex, "Temporary Admin" (multisig) appeared before "Keepers" (tokenVoting) because Keepers is an SPP sub-plugin (
isSubPlugin: true) even though it belongs to the root DAO.The fix uses
daoAddressonly for root detection. The type priority map (tokenVoting: 1, multisig: 2, lockToVote: 3) now correctly determines order within each group.See the example here:
/dao/ethereum-mainnet/0xf204245b0B05E9A0780761E326552A569c1D6ceb/membersBefore: Temporary Admin → Keepers → Liquidity Strategy Multisig → Admin
After: Keepers → Temporary Admin → Liquidity Strategy Multisig → Admin
Type of Change
Developer Checklist:
Review Checklist: