Skip to content

fix(APP-592): Correctly sort bodies plugin bodies by grouping #1091

Merged
milosh86 merged 8 commits into
mainfrom
app-592-change-order-of-bodies-in-member-list
Apr 15, 2026
Merged

fix(APP-592): Correctly sort bodies plugin bodies by grouping #1091
milosh86 merged 8 commits into
mainfrom
app-592-change-order-of-bodies-in-member-list

Conversation

@thekidnamedkd
Copy link
Copy Markdown
Contributor

Description

The plugin sort in useDaoPlugins was using isSubPlugin alongside daoAddress to determine root-DAO membership. This conflated SPP parent-child plugin relationships with linked account (DAO-to-DAO) relationships, causing tokenVoting sub-plugins on the root DAO to sort after standalone multisig plugins.

For example on Cryptex, "Temporary Admin" (multisig) appeared before "Keepers" (tokenVoting) because Keepers is an SPP sub-plugin (isSubPlugin: true) even though it belongs to the root DAO.

The fix uses daoAddress only for root detection. The type priority map (tokenVoting: 1, multisig: 2, lockToVote: 3) now correctly determines order within each group.

See the example here: /dao/ethereum-mainnet/0xf204245b0B05E9A0780761E326552A569c1D6ceb/members

Before: Temporary Admin → Keepers → Liquidity Strategy Multisig → Admin
After: Keepers → Temporary Admin → Liquidity Strategy Multisig → Admin

Type of Change

  • Patch: Bug fix (non-breaking change which fixes an issue)

Developer Checklist:

  • Manually smoke tested the functionality in a preview or locally
  • Confirmed there are no new warnings or errors in the browser console
  • (For User Stories only) Double-checked that all Acceptance Criteria are satisfied
  • Confirmed there are no new warnings on automated tests
  • Merged and published any dependent changes in downstream modules
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the Files Changed in Github's UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

Review Checklist:

  • (For User Stories only) Tested in a preview or locally that all Acceptance Criteria are satisfied
  • Confirmed that changes follow the code style guidelines of this project

@linear
Copy link
Copy Markdown

linear Bot commented Apr 15, 2026

@github-actions
Copy link
Copy Markdown

🚀 Preview Deployment: View Here

@github-actions
Copy link
Copy Markdown

E2E results (preview)

Smoke

Base URL https://app-next-8xpcr1f8v-aragon-app.vercel.app
Suite smoke
Playwright result ✅ passed
Summary 80 passed
HTML report View report
GitHub job ✅ completed

View run #4027

@thekidnamedkd thekidnamedkd marked this pull request as ready for review April 15, 2026 09:12
@thekidnamedkd thekidnamedkd requested a review from a team as a code owner April 15, 2026 09:12
Copy link
Copy Markdown
Contributor

@milosh86 milosh86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@milosh86 milosh86 merged commit 389d2ee into main Apr 15, 2026
17 checks passed
@milosh86 milosh86 deleted the app-592-change-order-of-bodies-in-member-list branch April 15, 2026 14:54
This was referenced Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants