Skip to content

Conversation

@evanaronson
Copy link
Contributor

@evanaronson evanaronson commented Nov 10, 2025

Description

Upgrading a plugin with no metadata will show a null in the proposal description. Fixed by removing that part of the string.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Developer Checklist:

  • Manually smoke tested the functionality locally (https://app-next-5dn4xoewn-aragon-app.vercel.app/dao/ethereum-sepolia/0x569fB583D896645475aE0D909D15Bc612F43450F/proposals/MULTISIG-14)
  • Confirmed there are no new warnings or errors in the browser console
  • (For User Stories only) Double-checked that all Acceptance Criteria are satisfied
  • Confirmed there are no new warnings on automated tests
  • Merged and published any dependent changes in downstream modules
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the Files Changed in Github’s UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

Review Checklist:

  • Tested locally that all Acceptance Criteria or Expected Outcomes are satisfied
  • Confirmed that changes follow the code style guidelines of this project

evanaronson and others added 2 commits November 10, 2025 15:35
Simplified the copy for the default OSx updates proposal.

Signed-off-by: Evan Aronson <93671071+evanaronson@users.noreply.github.com>
@linear
Copy link

linear bot commented Nov 10, 2025

@github-actions
Copy link

github-actions bot commented Nov 10, 2025

🚀 Preview Deployment: View Here

@evanaronson evanaronson marked this pull request as ready for review November 11, 2025 09:41
@thekidnamedkd thekidnamedkd merged commit 29bab64 into main Nov 11, 2025
10 checks passed
@thekidnamedkd thekidnamedkd deleted the fix-null-in-copy branch November 11, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants