Skip to content

feat(APP-334): Implement necessary changes for ProposalActionItem redesign #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
milosh86 merged 32 commits into from
Nov 25, 2025
Merged

feat(APP-334): Implement necessary changes for ProposalActionItem redesign #874

milosh86 merged 32 commits into from
Nov 25, 2025

Conversation

@thekidnamedkd
Copy link
Contributor

@thekidnamedkd thekidnamedkd commented Nov 20, 2025 •
edited
Loading

Description

Significant props and data structure

Type of Change

  • New feature (non-breaking change which adds functionality)

Developer Checklist:

  • Manually smoke tested the functionality locally
  • Confirmed there are no new warnings or errors in the browser console
  • (For User Stories only) Double-checked that all Acceptance Criteria are satisfied
  • Confirmed there are no new warnings on automated tests
  • Merged and published any dependent changes in downstream modules
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the Files Changed in Github’s UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

Review Checklist:

  • Tested locally that all Acceptance Criteria or Expected Outcomes are satisfied
  • Confirmed that changes follow the code style guidelines of this project

@thekidnamedkd
chore: begin fix for action movement
ed2616d
@thekidnamedkd
chore: align movement across field array, stabilize inputs, resolve n…
6b50ef8 
…ative transfers
@thekidnamedkd
chore: code cleanup, remove old file, rename HOC
47cff0a
@thekidnamedkd
Merge branch 'main' of github.com:aragon/app-next into app-247-moving…
d4b6b88 
…-actions-up-or-down-in-the-action-builder-crashes-the
@thekidnamedkd
chore: fix type errors
42f4a9b
@thekidnamedkd
fix: linting errors
d069edc
@thekidnamedkd
Merge branch 'main' of github.com:aragon/app-next into app-247-moving…
305cd70 
…-actions-up-or-down-in-the-action-builder-crashes-the
@thekidnamedkd
chore: save point
f2660c5
@thekidnamedkd
chore: save point
c50d39c
@thekidnamedkd
chore: code review cleanup
0609f7d
@thekidnamedkd
Merge branch 'main' of github.com:aragon/app-next into app-247-moving…
3059de3 
…-actions-up-or-down-in-the-action-builder-crashes-the
@thekidnamedkd
chore: adjust tests for necessary lint disable, remove unused method …
a36f4b6 
…+ docs
@thekidnamedkd
chore: include changeset
d15a358
@thekidnamedkd
chore: remove HOC changes
3a62882
@thekidnamedkd
chore: update snapshot
27305be
@thekidnamedkd
chore: update snapshot
c9aaefc
@thekidnamedkd
Merge branch 'main' of github.com:aragon/app-next into app-247-moving…
764620d 
…-actions-up-or-down-in-the-action-builder-crashes-the
@thekidnamedkd
chore: update snapshot
409775f
@thekidnamedkd
chore: update scroll behavior
969090d
@thekidnamedkd
chore: update snapshot
4787202
@linear
Copy link

linear bot commented Nov 20, 2025

APP-247 Moving actions up or down in the action builder crashes the app

APP-334 Remove accordions from the action builder

@github-actions
Copy link

github-actions bot commented Nov 20, 2025 •
edited
Loading

🚀 Preview Deployment: View Here

@thekidnamedkd thekidnamedkd marked this pull request as ready for review November 20, 2025 14:22
@thekidnamedkd thekidnamedkd changed the title feat(APP-334): Integrate new changes to ProposalActionItem redesign feat(APP-334): Integrate necessary changes for ProposalActionItem redesign Nov 20, 2025
@thekidnamedkd thekidnamedkd changed the title feat(APP-334): Integrate necessary changes for ProposalActionItem redesign feat(APP-334): Implement necessary changes for ProposalActionItem redesign Nov 20, 2025
@thekidnamedkd
Merge branch 'main' of github.com:aragon/app-next into app-247-moving…
4c8add3 
…-actions-up-or-down-in-the-action-builder-crashes-the
@thekidnamedkd
Merge branch 'main' of github.com:aragon/app-next into app-247-moving…
2500cff 
…-actions-up-or-down-in-the-action-builder-crashes-the
milosh86
milosh86 reviewed Nov 21, 2025
View reviewed changes
Copy link
Contributor

@milosh86 milosh86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks good, but I guess we wait for ui-kit first?

@milosh86 milosh86 merged commit 02f5684 into main Nov 25, 2025
10 checks passed
@milosh86 milosh86 deleted the app-247-moving-actions-up-or-down-in-the-action-builder-crashes-the branch November 25, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@milosh86 milosh86 milosh86 approved these changes

@tyhonchik tyhonchik Awaiting requested review from tyhonchik

Assignees

No one assigned

Labels

preview

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thekidnamedkd @milosh86