Skip to content

Comments

chore(APP-393): Hide veLocker chart preview when slope is flat#989

Merged
thekidnamedkd merged 3 commits intomainfrom
hide-with-format-check
Feb 23, 2026
Merged

chore(APP-393): Hide veLocker chart preview when slope is flat#989
thekidnamedkd merged 3 commits intomainfrom
hide-with-format-check

Conversation

@evanaronson
Copy link
Contributor

@evanaronson evanaronson commented Feb 15, 2026 •
edited
Loading

Description

Type of Change

  • Major: Breaking change (change that would cause existing functionality to not work as expected)
  • Minor: Feature (non-breaking change which adds new functionality)
  • Patch: Enhancement (non-breaking change to an existing feature)
  • Patch: Bug fix (non-breaking change which fixes an issue)

Developer Checklist:

  • Manually smoke tested the functionality in a preview or locally
  • Confirmed there are no new warnings or errors in the browser console
  • (For User Stories only) Double-checked that all Acceptance Criteria are satisfied
  • Confirmed there are no new warnings on automated tests
  • Merged and published any dependent changes in downstream modules
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the Files Changed in Github’s UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

Review Checklist:

  • (For User Stories only) Tested in a preview or locally that all Acceptance Criteria are satisfied
  • Confirmed that changes follow the code style guidelines of this project

@linear
Copy link

linear bot commented Feb 15, 2026

APP-393 Hide veLocker graph when reward multiplier is constant

@github-actions
Copy link

github-actions bot commented Feb 15, 2026 •
edited
Loading

🚀 Preview Deployment: View Here

@evanaronson evanaronson marked this pull request as ready for review February 15, 2026 18:19
@evanaronson evanaronson requested a review from a team as a code owner February 15, 2026 18:19
@evanaronson
Copy link
Contributor Author

evanaronson commented Feb 15, 2026

Proof of fix.

Not showing here:
https://app-next-i52eygp0q-aragon-app.vercel.app/dao/avax-mainnet/0xE142c9F8Bac2827AFE23C7F4Acf7b7E88b66a0D1/members?memberPanel=lock&members=0x5258F53293A8E4A71d3C102F54634610F9ceA7A6-asdf

Showing here:
https://app-next-i52eygp0q-aragon-app.vercel.app/dao/ethereum-sepolia/0xE8fd9Fe445A037ee07fb98FDD4b146d939140De5/members?memberPanel=lock&members=0x5a6d0C090B0018a7e05ef60b5c1058A74b03503e-tve

@thekidnamedkd thekidnamedkd changed the title enhance(APP-393): hide veLocker when slope is flat chore(APP-393): hide veLocker when slope is flat Feb 15, 2026
@thekidnamedkd thekidnamedkd changed the title chore(APP-393): hide veLocker when slope is flat chore(APP-393): Hide veLocker chart preview when slope is flat Feb 15, 2026
thekidnamedkd
thekidnamedkd reviewed Feb 15, 2026
View reviewed changes
Copy link
Contributor

@thekidnamedkd thekidnamedkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one suggestion.

tyhonchik
tyhonchik approved these changes Feb 23, 2026
View reviewed changes
Copy link
Contributor

@tyhonchik tyhonchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thekidnamedkd thekidnamedkd merged commit 70f14e8 into main Feb 23, 2026
16 checks passed
@thekidnamedkd thekidnamedkd deleted the hide-with-format-check branch February 23, 2026 12:47
@arabot-1 arabot-1 mentioned this pull request Feb 23, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thekidnamedkd thekidnamedkd thekidnamedkd left review comments

@tyhonchik tyhonchik tyhonchik approved these changes

Assignees

No one assigned

Labels

preview

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@evanaronson @tyhonchik @thekidnamedkd