This repository was archived by the owner on May 22, 2025. It is now read-only.
Feat: Add descriptions utils for evm scripts and transactions#101
Merged
Feat: Add descriptions utils for evm scripts and transactions#101
Conversation
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
==========================================
- Coverage 28.12% 26.23% -1.89%
==========================================
Files 54 56 +2
Lines 889 953 +64
Branches 145 150 +5
==========================================
Hits 250 250
- Misses 639 703 +64
Continue to review full report at Codecov.
|
0xGabi
commented
Jul 3, 2020
| @@ -0,0 +1,40 @@ | |||
| import { connect, describeScript, App } from '@aragon/connect' | |||
Contributor
Author
There was a problem hiding this comment.
Example of how to use describeScript to decode script from votes.
0xGabi
commented
Jul 3, 2020
| @@ -0,0 +1,4 @@ | |||
| export { findAppMethodFromIntent } from './app' | |||
Contributor
Author
There was a problem hiding this comment.
I decided to expose this utilities, what you think?
bpierre
approved these changes
Jul 5, 2020
Contributor
bpierre
left a comment
bpierre
left a comment
There was a problem hiding this comment.
LGTM! Should we document these at some point?
| @@ -0,0 +1,4 @@ | |||
| export { findAppMethodFromIntent } from './app' | |||
Co-authored-by: Pierre Bertet <hello@pierre.world>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes a utility to describe EVM scripts and transactions.
It exposes a few of the utils we use on
connect-coreto be accessible fromconnect.It includes an example of how to use
decodeScriptto decode a script from a vote.