Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

App filters + align Organization methods#111

Merged
bpierre merged 8 commits intomasterfrom
app-filters
Jul 5, 2020
Merged

App filters + align Organization methods#111
bpierre merged 8 commits intomasterfrom
app-filters

Conversation

@bpierre
Copy link
Copy Markdown
Contributor

@bpierre bpierre commented Jul 5, 2020

Fixes #48

  • Add an Organization#onApp() method.
  • Add app filters to:
    • Organization#app()
    • Organization#apps()
    • Organization#onApp()
    • Organization#onApps()
  • Update Organization API docs (remove anything not implemented).

- Add an Organization#onApp() method.
- Add app filters to:
  - Organization#app()
  - Organization#apps()
  - Organization#onApp()
  - Organization#onApps()
- Update Organization API docs (remove anything not implemented).
@bpierre bpierre requested review from 0xGabi and sohkai July 5, 2020 11:30
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 5, 2020

Codecov Report

Merging #111 into master will decrease coverage by 4.46%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   28.12%   23.65%   -4.47%     
==========================================
  Files          54       60       +6     
  Lines         889     1154     +265     
  Branches      145      198      +53     
==========================================
+ Hits          250      273      +23     
- Misses        639      881     +242     
Flag Coverage Δ
#unittests 23.65% <14.28%> (-4.47%) ⬇️
Impacted Files Coverage Δ
...ages/connect-core/src/connections/ConnectorJson.ts 0.00% <0.00%> (ø)
packages/connect-core/src/entities/Organization.ts 0.00% <0.00%> (ø)
packages/connect-core/src/utils/misc.ts 0.00% <0.00%> (ø)
packages/connect-thegraph/src/queries/index.ts 100.00% <ø> (ø)
packages/connect-thegraph/src/connector.ts 60.46% <47.05%> (-11.95%) ⬇️
...ckages/connect-thegraph/src/core/GraphQLWrapper.ts 44.44% <100.00%> (+1.04%) ⬆️
packages/connect-core/src/index.ts 0.00% <0.00%> (ø)
packages/connect-core/src/entities/Role.ts 0.00% <0.00%> (ø)
packages/connect-core/src/utils/transactions.ts 0.00% <0.00%> (ø)
packages/connect-core/src/utils/radspec/index.ts 0.00% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43280b1...bd52b37. Read the comment docs.

@bpierre bpierre mentioned this pull request Jul 5, 2020
Copy link
Copy Markdown
Contributor

@0xGabi 0xGabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look really good!! 🚀

Comment thread docs/guides/getting-started.md Outdated
Comment thread packages/connect-core/src/connections/ConnectorInterface.ts
Comment thread packages/connect-core/src/entities/Organization.ts
Comment thread packages/connect-thegraph/src/connector.ts
@bpierre bpierre merged commit 95271d1 into master Jul 5, 2020
@bpierre bpierre deleted the app-filters branch July 5, 2020 19:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add filters to org.app() and org.apps()

2 participants