Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Docs: Use or as separators#118

Merged
0xGabi merged 2 commits intomasterfrom
use-github-separators
Jul 6, 2020
Merged

Docs: Use or as separators#118
0xGabi merged 2 commits intomasterfrom
use-github-separators

Conversation

@0xGabi
Copy link
Copy Markdown
Contributor

@0xGabi 0xGabi commented Jul 6, 2020

@bpierre I wonder if maybe we should use or as we did in a few places.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 6, 2020

Codecov Report

Merging #118 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   24.12%   24.12%           
=======================================
  Files          59       59           
  Lines        1032     1032           
  Branches      167      167           
=======================================
  Hits          249      249           
  Misses        783      783           
Flag Coverage Δ
#unittests 24.12% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d237023...1c5b996. Read the comment docs.

@bpierre
Copy link
Copy Markdown
Contributor

bpierre commented Jul 6, 2020

@bpierre I wonder if maybe we should use or as we did in a few places.

Yes let’s do this! We were talking with @sohkai about perhaps defining somewhere this pseudo language we use to define the types in the documentation (e.g. “How to read this documentation” in the intro page).

@0xGabi 0xGabi merged commit 46e9437 into master Jul 6, 2020
@0xGabi 0xGabi deleted the use-github-separators branch July 6, 2020 14:41
@0xGabi 0xGabi changed the title Docs: Use \| as separators Docs: Use or as separators Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants