Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Types: remove some non-null assertion operators (!)#128

Merged
bpierre merged 1 commit intomasterfrom
simplify-types
Jul 18, 2020
Merged

Types: remove some non-null assertion operators (!)#128
bpierre merged 1 commit intomasterfrom
simplify-types

Conversation

@bpierre
Copy link
Copy Markdown
Contributor

@bpierre bpierre commented Jul 9, 2020

Also remove unnecessary undefined assignments.

@bpierre bpierre requested a review from 0xGabi July 9, 2020 11:09
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 9, 2020

Codecov Report

Merging #128 into master will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   23.92%   23.97%   +0.04%     
==========================================
  Files          59       59              
  Lines        1049     1047       -2     
  Branches      168      160       -8     
==========================================
  Hits          251      251              
+ Misses        798      796       -2     
Flag Coverage Δ
#unittests 23.97% <0.00%> (+0.04%) ⬆️
Impacted Files Coverage Δ
packages/connect-core/src/entities/App.ts 0.00% <0.00%> (ø)
packages/connect-core/src/entities/Repo.ts 0.00% <0.00%> (ø)
packages/connect-core/src/utils/metadata.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f2b91f...2ecb0b7. Read the comment docs.

@bpierre bpierre mentioned this pull request Jul 9, 2020
Copy link
Copy Markdown
Contributor

@0xGabi 0xGabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@bpierre bpierre merged commit 19b6da8 into master Jul 18, 2020
@bpierre bpierre deleted the simplify-types branch July 18, 2020 20:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants