This repository was archived by the owner on May 22, 2025. It is now read-only.
Types: add SubscriptionHandler, Address#136
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
=======================================
Coverage 23.92% 23.92%
=======================================
Files 59 59
Lines 1049 1049
Branches 168 168
=======================================
Hits 251 251
Misses 798 798
Continue to review full report at Codecov.
|
0xGabi
approved these changes
Jul 15, 2020
| @@ -25,7 +25,7 @@ Like `Organization#app()`, but as a subscription. | |||
| | `appFilter.address` | `String` | Same as `appFilter`, but makes the selection by `address` explicit. | | |||
Contributor
There was a problem hiding this comment.
I wonder what you think of using the types (Address and SubscriptionHandler) on the documentation as well. And maybe we should have a new documentation page with all the types we currently have?
Contributor
Author
There was a problem hiding this comment.
Yes definitely, I think we could have a page for the types somewhere. :+1:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracting some changes out of #135 to make it easier to review.