Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Use fixed version ranges#184

Merged
bpierre merged 2 commits intomasterfrom
fixed-version-ranges
Aug 4, 2020
Merged

Use fixed version ranges#184
bpierre merged 2 commits intomasterfrom
fixed-version-ranges

Conversation

@bpierre
Copy link
Copy Markdown
Contributor

@bpierre bpierre commented Aug 4, 2020

Fixes #175

Using * could prevent bundlers to separate the versions of internal packages (e.g. webpack with ethers).

Also updates oao to version 2.

@bpierre bpierre requested a review from 0xGabi August 4, 2020 18:43
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 4, 2020

Codecov Report

Merging #184 into master will increase coverage by 6.71%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
+ Coverage   20.43%   27.14%   +6.71%     
==========================================
  Files          69       81      +12     
  Lines        1282     1477     +195     
  Branches      234      251      +17     
==========================================
+ Hits          262      401     +139     
- Misses       1020     1076      +56     
Flag Coverage Δ
#unittests 27.14% <ø> (+6.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/connect-agreement/src/entities/Signature.ts 100.00% <0.00%> (ø)
...onnect-agreement/src/thegraph/parsers/agreement.ts 80.00% <0.00%> (ø)
...es/connect-agreement/src/thegraph/queries/index.ts 100.00% <0.00%> (ø)
...connect-agreement/src/thegraph/parsers/versions.ts 82.35% <0.00%> (ø)
packages/connect-agreement/src/entities/Signer.ts 76.47% <0.00%> (ø)
...es/connect-agreement/src/thegraph/parsers/index.ts 100.00% <0.00%> (ø)
packages/connect-agreement/src/connect.ts 40.00% <0.00%> (ø)
packages/connect-agreement/src/entities/Version.ts 100.00% <0.00%> (ø)
...ckages/connect-agreement/src/thegraph/connector.ts 52.72% <0.00%> (ø)
.../connect-agreement/src/thegraph/parsers/signers.ts 84.61% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c542a4...88ae5f0. Read the comment docs.

Copy link
Copy Markdown
Contributor

@0xGabi 0xGabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I tested against the honey-pot repo and is working fine now!

@bpierre bpierre merged commit 379c45b into master Aug 4, 2020
@bpierre bpierre deleted the fixed-version-ranges branch August 4, 2020 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade oao to 2.0

2 participants