Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Update app connectors models and types#191

Merged
0xGabi merged 4 commits intomasterfrom
app-connectors-style
Aug 5, 2020
Merged

Update app connectors models and types#191
0xGabi merged 4 commits intomasterfrom
app-connectors-style

Conversation

@0xGabi
Copy link
Copy Markdown
Contributor

@0xGabi 0xGabi commented Aug 5, 2020

This PR includes two changes:

  1. Rename connector entities -> models
  2. Move data interfaces into types file.

The changes were done on the Voting, Tokens, and Finance app connectors.

@0xGabi 0xGabi requested a review from bpierre August 5, 2020 16:33
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 5, 2020

Codecov Report

Merging #191 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   32.68%   32.68%           
=======================================
  Files          96       96           
  Lines        1741     1741           
  Branches      273      273           
=======================================
  Hits          569      569           
  Misses       1172     1172           
Flag Coverage Δ
#unittests 32.68% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/connect-finance/src/models/Finance.ts 5.55% <ø> (ø)
packages/connect-finance/src/models/Transaction.ts 100.00% <ø> (ø)
packages/connect-finance/src/thegraph/connector.ts 54.83% <ø> (ø)
packages/connect-tokens/src/models/Token.ts 100.00% <ø> (ø)
packages/connect-tokens/src/models/TokenHolder.ts 100.00% <ø> (ø)
packages/connect-tokens/src/models/Tokens.ts 86.66% <ø> (ø)
packages/connect-tokens/src/thegraph/connector.ts 76.47% <ø> (ø)
packages/connect-voting/src/models/Vote.ts 90.00% <ø> (ø)
packages/connect-voting/src/models/Voting.ts 7.69% <ø> (ø)
packages/connect-voting/src/thegraph/connector.ts 54.83% <ø> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be665e...2be8630. Read the comment docs.

@0xGabi 0xGabi merged commit 739148c into master Aug 5, 2020
@0xGabi 0xGabi deleted the app-connectors-style branch August 5, 2020 16:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants