This repository was archived by the owner on May 22, 2025. It is now read-only.
Merged
Conversation
Also moved the network-related functions into network.ts.
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
==========================================
- Coverage 34.96% 34.90% -0.06%
==========================================
Files 98 99 +1
Lines 1799 1799
Branches 276 276
==========================================
- Hits 629 628 -1
- Misses 1170 1171 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
0xGabi
approved these changes
Aug 14, 2020
Contributor
0xGabi
left a comment
0xGabi
left a comment
There was a problem hiding this comment.
Thanks, super concise, and clean PR. I think it checks all of the boxes for what we should aim for:
- Specific change
- Small change
- Tested
|
|
||
| // Just a little help for TypeScript, at this | ||
| // point we know that chainId cannot be undefined. | ||
| chainId = chainId as number |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also moved the network-related functions into network.ts.