This repository was archived by the owner on May 22, 2025. It is now read-only.
App connectors: align subscription methods#240
Merged
Conversation
Fixes an issue on the Tokens connector where onHolders() was using the address of the app rather than the address of the token contract. Also the method now accepts filters like its async counterpart.
The method now accepts filters like its async counterpart.
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
==========================================
+ Coverage 36.68% 36.70% +0.02%
==========================================
Files 104 104
Lines 1922 1926 +4
Branches 304 306 +2
==========================================
+ Hits 705 707 +2
- Misses 1217 1219 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns the subscription methods with their async counterparts for the Finance, Voting and Tokens app connectors.
It is a breaking change.