Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Removed GraphQL types#70

Merged
eternauta1337 merged 5 commits intomasterfrom
no-grapqhql-types
Jun 24, 2020
Merged

Removed GraphQL types#70
eternauta1337 merged 5 commits intomasterfrom
no-grapqhql-types

Conversation

@eternauta1337
Copy link
Copy Markdown
Contributor

Our GraphQL connectors were using a 3rd party utility for converting GraphQL schema to Typescript types. This was an interesting "toy" but not something really practical. In fact, we made several updates to our subgraphs and never bothered to update our generated types, so the existing types were moderately incorrect.

The added value of having types on this is very small with our current architecture, since we parse all values into a type we control. Keeping these types around is a nuisance.

Copy link
Copy Markdown
Contributor

@0xGabi 0xGabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, make sense for the connectors!

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 24, 2020

Codecov Report

Merging #70 into master will not change coverage.
The diff coverage is 94.73%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
  Coverage   28.15%   28.15%           
=======================================
  Files          53       53           
  Lines         863      863           
  Branches      146      146           
=======================================
  Hits          243      243           
  Misses        620      620           
Flag Coverage Δ
#unittests 28.15% <94.73%> (ø)
Impacted Files Coverage Δ
packages/connect-thegraph/src/parsers/roles.ts 70.37% <80.00%> (ø)
...thegraph-token-manager/src/parsers/tokenHolders.ts 90.90% <100.00%> (ø)
...nnect-thegraph-token-manager/src/parsers/tokens.ts 87.50% <100.00%> (ø)
...kages/connect-thegraph-voting/src/parsers/casts.ts 90.90% <100.00%> (ø)
...kages/connect-thegraph-voting/src/parsers/votes.ts 90.90% <100.00%> (ø)
packages/connect-thegraph/src/parsers/apps.ts 92.59% <100.00%> (ø)
...ckages/connect-thegraph/src/parsers/permissions.ts 87.50% <100.00%> (ø)
packages/connect-thegraph/src/parsers/repos.ts 92.30% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6b5bf3...1f4be11. Read the comment docs.

@eternauta1337 eternauta1337 merged commit 8434ba4 into master Jun 24, 2020
@eternauta1337 eternauta1337 deleted the no-grapqhql-types branch June 24, 2020 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants