This repository was archived by the owner on May 22, 2025. It is now read-only.
Removed GraphQL types#70
Merged
eternauta1337 merged 5 commits intomasterfrom Jun 24, 2020
Merged
Conversation
0xGabi
approved these changes
Jun 23, 2020
Contributor
0xGabi
left a comment
There was a problem hiding this comment.
I agree, make sense for the connectors!
bpierre
approved these changes
Jun 24, 2020
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
=======================================
Coverage 28.15% 28.15%
=======================================
Files 53 53
Lines 863 863
Branches 146 146
=======================================
Hits 243 243
Misses 620 620
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our GraphQL connectors were using a 3rd party utility for converting GraphQL schema to Typescript types. This was an interesting "toy" but not something really practical. In fact, we made several updates to our subgraphs and never bothered to update our generated types, so the existing types were moderately incorrect.
The added value of having types on this is very small with our current architecture, since we parse all values into a type we control. Keeping these types around is a nuisance.