Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Token manager subgraph: Fix duplicated balances#75

Merged
bpierre merged 3 commits intoaragon:masterfrom
fabriziovigevani:duplicate-balances-fix
Jun 26, 2020
Merged

Token manager subgraph: Fix duplicated balances#75
bpierre merged 3 commits intoaragon:masterfrom
fabriziovigevani:duplicate-balances-fix

Conversation

@fabriziovigevani
Copy link
Copy Markdown
Contributor

@fabriziovigevani fabriziovigevani commented Jun 24, 2020

Fixes duplicated balances issue.

From the graph docs

The BigInt class has the following API:

Construction

BigInt.fromI32(x: i32): BigInt – creates a BigInt from an i32

I think when using new BigInt() the previousBlock had an unexpected value.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 24, 2020

Codecov Report

Merging #75 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #75   +/-   ##
=======================================
  Coverage   28.15%   28.15%           
=======================================
  Files          53       53           
  Lines         863      863           
  Branches      146      146           
=======================================
  Hits          243      243           
  Misses        620      620           
Flag Coverage Δ
#unittests 28.15% <ø> (ø)
Impacted Files Coverage Δ
...kages/connect-thegraph-tokens/src/queries/index.ts
...onnect-thegraph-tokens/src/entities/TokenHolder.ts
...onnect-thegraph-tokens/src/parsers/tokenHolders.ts
...kages/connect-thegraph-tokens/src/parsers/index.ts
...nnect-thegraph-tokens/src/entities/TokenManager.ts
...ages/connect-thegraph-tokens/src/parsers/tokens.ts
packages/connect-thegraph-tokens/src/connector.ts
...nnect-thegraph-tokens/src/entities/TokensEntity.ts
...ages/connect-thegraph-tokens/src/entities/Token.ts
packages/connect-thegraph-tokens/src/index.ts
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 339dded...4524184. Read the comment docs.

Copy link
Copy Markdown
Contributor

@bpierre bpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it seems to be the only case in the code base. Thanks Fabri 🙏

@bpierre bpierre merged commit b1edace into aragon:master Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants