This repository was archived by the owner on May 22, 2025. It is now read-only.
docs: dedupe subgraph and connector guides#88
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
- Coverage 29.10% 28.40% -0.70%
==========================================
Files 53 53
Lines 835 873 +38
Branches 135 148 +13
==========================================
+ Hits 243 248 +5
- Misses 592 625 +33
Continue to review full report at Codecov.
|
bpierre
approved these changes
Jun 27, 2020
0xGabi
reviewed
Jun 27, 2020
Contributor
0xGabi
left a comment
0xGabi
left a comment
There was a problem hiding this comment.
I leave a few suggestions. I think the split between subgraph and connector is a good one 👍
Co-authored-by: Gabriel Garcia <gabrielpk.18@gmail.com>
Contributor
Author
|
Thanks for the review @0xGabi, I've applied all the suggestions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deduplicates the information that was the same in the app connector guide with the information available in the subgraph guide.
Also adds the app subgraph guide to shown on Gitbooks.