Docs: Add more information about Connectors#95
Conversation
| const { votes } = results.data | ||
| ``` | ||
|
|
||
| {% hint style="warning" %} |
There was a problem hiding this comment.
Note this is the syntax that GitBook use to create hints.
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
- Coverage 28.99% 27.15% -1.85%
==========================================
Files 53 55 +2
Lines 838 939 +101
Branches 137 157 +20
==========================================
+ Hits 243 255 +12
- Misses 595 684 +89
Continue to review full report at Codecov.
|
Evalir
left a comment
Evalir
left a comment
There was a problem hiding this comment.
Adding some suggestions over the docs! It's looking so clear already 🔥
Co-authored-by: Enrique Ortiz <enrique@aragon.one>
|
@Evalir thanks a lot for the review 🙏 |
bpierre
left a comment
bpierre
left a comment
There was a problem hiding this comment.
LGTM apart from a few comments, mostly nitpicking! ✂️
| const wrapper = new GraphQLWrapper(VOTING_SUBGRAPH_URL) | ||
|
|
||
| // Fetch the data performing the custom query | ||
| const results = await wrapper.performQuery(gql(QUERY)) |
There was a problem hiding this comment.
I don’t think gql(QUERY) would work? We should probably do this instead:
const QUERY = gql`
# …
`There was a problem hiding this comment.
I like more the option you propose. Regardless the other way also works because I check on 1Hive's honey-pot and it's writing like gql(QUERY)
There was a problem hiding this comment.
Interesting, I imagine gql checks if it receives an array of strings or a string, and adapt its behavior to work in both cases 🤔
Edit: Yes 😄 https://github.com/apollographql/graphql-tag/blob/9b719a77530b81acc48be238e2dee3cf28e65beb/src/index.js#L158
| @@ -0,0 +1,84 @@ | |||
| # Answering questions with custom queries | |||
There was a problem hiding this comment.
Just as a note, GitBook doesn’t like file names that don’t match the title (that’s why we have e.g. transactionrequest.md rather than transaction-request.md), but I don’t think it matters since we protected the master branch.
Co-authored-by: Pierre Bertet <hello@pierre.world>
3 participants
No description provided.