Checkbox styling - Utility Class #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renestalder
approved these changes
Jul 22, 2024
| } | ||
|
|
||
| .whatwedo_core-checkbox { | ||
| @apply text-primary-500 focus:ring-1 focus:ring-primary-500 rounded cursor-pointer; |
There was a problem hiding this comment.
Nit: Checkboxes and other form elements usually do not have a pointer cursor by default (not even natively in the operating system). But I also do not have any information where this requirement is coming from.
Contributor
Author
There was a problem hiding this comment.
@renestalder Interesting insights. I didn't know that.
I took this attribute from another field and wasn't thinking about the. general behaviour of checkbox.
Would you recommend keeping it there or removing it?
tuxes3
pushed a commit
that referenced
this pull request
Oct 8, 2024
Fix datetime and add options to Stimulus Controller (Meta #35)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.