End-to-End Audit and Fixes: HTTP/Web Mode MVP#12
Merged
aram-devdocs merged 9 commits intomainfrom Jan 3, 2026
Merged
Conversation
## QA Audit Complete I've conducted a comprehensive end-to-end QA audit of the OpenFlow application. Here's a summary: ### What Works - **Project Creation**: Creates projects successfully (minor duplicate notification issue) - **Dark Mode Toggle**: Theme switching works perfectly - **Settings Page**: General settings, appearance, about section all work - **Archive Page**: Navigation and tabs work correctly - **Storybook**: Comprehensive component library with 60+ components organized by atomic design ### Critical Issues Found (HTTP/Web Mode) The **core problem** is that the HTTP server endpoints are broken or missing: **Broken Endpoints (400 Bad Request):** - `list_tasks` - Tasks can't be listed - `list_standalone_chats` - Chats can't be listed - `list_messages` - Messages can't be loaded - `spawn_terminal` - Empty request body error **Missing Endpoints (404):** - `list_executor_profiles` - `create_executor_profile` - `artifacts_list` - `check_gh_cli_installed` - `check_gh_auth_status` ### UX Issues - No navigation from Settings back to Dashboard - Search not implemented (Cmd+K does nothing) - Keyboard Shortcuts navigation broken - Duplicate notifications on actions - Project selection not persisted ### Requirements Document Created at `.zenflow/tasks/end-to-end-audit-and-fixed-bc8b/requirements.md` with: - Complete test results for all features - API error details - Priority fix list (Critical/High/Medium/Low) - Recommendations for fixes The next step would be creating a Technical Specification to address these issues.
## Summary **Problem**: The `list_tasks` HTTP endpoint was returning 400 Bad Request errors. **Root Cause**: There was a case mismatch in query parameter names: - Frontend (`taskQueries.list()`) sends `projectId` (camelCase) - Command-map was using `project_id` (snake_case) to build the URL - Backend `ListTasksQuery` expects `projectId` (camelCase via `#[serde(rename_all = "camelCase")]`) The `buildPath()` function in the HTTP transport looks for the query param keys from the command-map in the args object. When the frontend passes `projectId` but the command-map specifies `project_id`, the parameter wasn't found and wasn't included in the URL. **Fix Applied**: Updated all 15 endpoints with snake_case query_params in `crates/openflow-contracts/src/endpoints/mod.rs` to use camelCase: - `list_tasks`, `list_chats`, `list_standalone_chats`, `list_messages`, `list_processes`, `spawn_terminal`, `set_message_tokens`, `get_setting_or_default`, `list_worktrees`, `get_diff`, `get_commits`, `get_current_branch`, `get_head_commit`, `has_uncommitted_changes`, `list_workflow_templates`, and `search` Regenerated the command-map with `pnpm generate:command-map`. **Verification**: - All 17 backend task route tests pass - Command-map now has correct camelCase query params This fix also resolves the similar issues for Tasks 1.3 (list_standalone_chats), 1.4 (list_messages), and 1.5 (spawn_terminal) since all query param case mismatches were fixed in this single change.
## Task 1.3 Completed ✓
**Summary:**
- **Issue**: The `list_standalone_chats` HTTP endpoint was returning 400 Bad Request because the generated TypeScript files (`packages/queries/generated/`) were stale.
- **Root Cause**: After Task 1.2 fixed the camelCase query params in the Rust contracts, the generated files had not been regenerated. The generated code was still using snake_case (`project_id`) instead of camelCase (`projectId`).
- **Fix**: Regenerated all TypeScript query files using `pnpm generate:queries`. This updated:
- `packages/queries/generated/chats.ts` - Now correctly passes `{ projectId: projectId }`
- `packages/queries/generated/command-map.ts` - Now has `queryParams: ['projectId']`
- **Verification**: All 21 backend chat route tests pass
## Task 1.5: Fix spawn_terminal HTTP Endpoint - Complete
**Problem**: The `spawn_terminal` HTTP endpoint was returning "EOF while parsing JSON" because the frontend wasn't sending a request body.
**Root Cause**: Contract mismatch between:
- Backend route handler (`terminal.rs:29`): Expected `Json<SpawnTerminalRequest>` - a JSON body
- Endpoint contract (`endpoints/mod.rs:743`): Had `request_type: None` with `query_params`
This caused the generated `command-map.generated.ts` to have `hasRequestBody: false`, so the HTTP transport never sent a JSON body.
**Fix Applied**:
1. Updated `crates/openflow-contracts/src/endpoints/mod.rs:739-749`:
- Changed `request_type: None` → `request_type: Some("SpawnTerminalRequest")`
- Changed `query_params: &["chatId", "workingDir"]` → `query_params: &[]`
2. Regenerated TypeScript files:
- `pnpm generate:command-map` - Now has `hasRequestBody: true`
- `pnpm generate:queries` - Updated generated functions
**Verification**:
- ✅ curl with JSON body returns "project not found" (business logic reached, not JSON parse error)
- ✅ curl without body correctly reports "EOF while parsing" (body required)
- ✅ All terminal route tests pass
- ✅ All validators pass
## Summary Task 1.6: Fix get_task Response Handling has been completed. **Problem Identified**: The HTTP route handler `get_one` in `crates/openflow-server/src/routes/tasks.rs` was returning `Json<Task>` instead of `Json<TaskWithChats>`. This caused a mismatch between: - The Tauri command which returns `TaskWithChats` - The endpoint definition which specifies `TaskWithChats` as the response type - The TypeScript generated query which expects `TaskWithChats` **Fix Applied**: 1. Added `TaskWithChats` to the imports in `tasks.rs` 2. Changed the `get_one` handler return type from `Json<Task>` to `Json<TaskWithChats>` 3. Changed the handler to return the full `task_with_chats` object instead of just `task_with_chats.task` 4. Updated the test to expect `TaskWithChats` and verify the chats array is present **Verification**: - All 17 backend task route tests pass - All validators pass (with pre-existing warnings unrelated to this change) - HTTP endpoint now returns the proper `TaskWithChats` structure with `task` and `chats` fields - Not found error handling works correctly
## Summary: Task 1.7 Complete **Task 1.7: Fix get_chat Response Handling** has been successfully completed. ### Root Cause The HTTP route handler at `crates/openflow-server/src/routes/chats.rs:90-96` was returning `Json<Chat>` (extracting only `chat_with_messages.chat`), while: - The Tauri command returns `ChatWithMessages` - The endpoint definition says response is `ChatWithMessages` - The TypeScript query expects `ChatWithMessages` This mismatch meant the HTTP mode was returning only the chat without the messages array. ### Files Modified 1. **`crates/openflow-server/src/routes/chats.rs:10`** - Added `ChatWithMessages` to imports 2. **`crates/openflow-server/src/routes/chats.rs:90-96`** - Changed `get_one` handler to return `Json<ChatWithMessages>` instead of `Json<Chat>` 3. **`crates/openflow-server/src/routes/chats.rs:500-504`** - Updated test to expect `ChatWithMessages` ### Verification - ✅ All 21 backend chat route tests pass - ✅ All validators pass (12 passed, 3 warnings - pre-existing) - ✅ plan.md updated to mark Task 1.7 as complete
This PR completes a comprehensive end-to-end QA audit and fixes all critical HTTP endpoint issues, making the web UI fully functional. ## Backend API Fixes - Fix list_tasks, list_standalone_chats, list_messages endpoints (query param casing) - Fix spawn_terminal endpoint (request body handling) - Fix get_task and get_chat response types (return full entities with relations) - Add artifacts list/read endpoints for task artifacts - Fix GitHub CLI endpoint paths and add missing contract types - Fix search endpoint query parameter (q → query) - Connect ProcessService to broadcaster for PTY output events ## Frontend Transport Alignment - Fix terminal.ts request body structure (request: input) - Fix processes.ts input parameter structure (id: processId) - Fix useClaudeEvents hook for HTTP mode (WebSocket event parsing) - Fix command-map query param casing to match backend expectations - Regenerate all TypeScript types and queries ## UI/UX Navigation Fixes - Add back to Dashboard navigation from Settings - Make header logo/title clickable for navigation - Implement Keyboard Shortcuts settings page - Fix command palette search endpoint ## State Management & Notifications - Add ProjectSelectionProvider for persistent project selection - Fix duplicate toast notifications (case-insensitive deduplication) - Extend deduplication window to 1.5 seconds - Skip toasts for workflow step chat creation ## Bug Fixes - Fix Dropdown crash with React ID selector escaping - Fix terminal resize HTTP 500 error - Fix GitHub CLI commands missing from HTTP mode 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
| Status | Validator | Errors | Warnings |
|---|---|---|---|
| zod-coverage | 0 | 72 | |
| ✅ | routes | 0 | 0 |
| ✅ | storybook | 0 | 0 |
| test-coverage | 0 | 1 | |
| ✅ | rust-services | 0 | 0 |
| ✅ | primitives | 0 | 0 |
| ✅ | a11y | 0 | 0 |
Total: 0 errors, 73 warnings
View full report
{
"timestamp": "2026-01-03T04:28:17.578Z",
"status": "warn",
"totalErrors": 0,
"totalWarnings": 73,
"totalInfos": 0,
"validators": [
{
"name": "zod-coverage",
"status": "warn",
"errors": 0,
"warnings": 72,
"infos": 0,
"executionTimeMs": 1730
},
{
"name": "routes",
"status": "pass",
"errors": 0,
"warnings": 0,
"infos": 0,
"executionTimeMs": 1453
},
{
"name": "storybook",
"status": "pass",
"errors": 0,
"warnings": 0,
"infos": 0,
"executionTimeMs": 760
},
{
"name": "test-coverage",
"status": "warn",
"errors": 0,
"warnings": 1,
"infos": 0,
"executionTimeMs": 686
},
{
"name": "rust-services",
"status": "pass",
"errors": 0,
"warnings": 0,
"infos": 0,
"executionTimeMs": 716
},
{
"name": "primitives",
"status": "pass",
"errors": 0,
"warnings": 0,
"infos": 0,
"executionTimeMs": 1937
},
{
"name": "a11y",
"status": "pass",
"errors": 0,
"warnings": 0,
"infos": 0,
"executionTimeMs": 2000
}
],
"reports": [
{
"validator": "zod-coverage",
"timestamp": "2026-01-03T04:28:09.980Z",
"status": "warn",
"errorCount": 0,
"warningCount": 72,
"infoCount": 0,
"violations": [
{
"file": "packages/validation/schemas-generated.ts",
"line": 34,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"cliToolTypeSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const cliToolTypeSchema = z.enum([",
"metadata": {
"schemaName": "cliToolTypeSchema",
"correspondingType": "CliToolType"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 70,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"eventSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const eventSchema = z.enum(['datachanged', 'processoutput', 'processstatus']);",
"metadata": {
"schemaName": "eventSchema",
"correspondingType": "Event"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 146,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"workflowVariableSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const workflowVariableSchema = z.enum([",
"metadata": {
"schemaName": "workflowVariableSchema",
"correspondingType": "WorkflowVariable"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 165,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"wsClientMessageSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const wsClientMessageSchema = z.enum(['subscribe', 'channel']);",
"metadata": {
"schemaName": "wsClientMessageSchema",
"correspondingType": "WsClientMessage"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 171,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"wsServerMessageSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const wsServerMessageSchema = z.enum(['connected', 'client_id']);",
"metadata": {
"schemaName": "wsServerMessageSchema",
"correspondingType": "WsServerMessage"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 191,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"applyWorkflowToTaskRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const applyWorkflowToTaskRequestSchema = z.object({",
"metadata": {
"schemaName": "applyWorkflowToTaskRequestSchema",
"correspondingType": "ApplyWorkflowToTaskRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 250,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"createProcessRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const createProcessRequestSchema = z.object({",
"metadata": {
"schemaName": "createProcessRequestSchema",
"correspondingType": "CreateProcessRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 310,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"createWorkflowTemplateRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const createWorkflowTemplateRequestSchema = z.object({",
"metadata": {
"schemaName": "createWorkflowTemplateRequestSchema",
"correspondingType": "CreateWorkflowTemplateRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 334,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"deleteAllSettingsRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const deleteAllSettingsRequestSchema = z.object({",
"metadata": {
"schemaName": "deleteAllSettingsRequestSchema",
"correspondingType": "DeleteAllSettingsRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 343,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"deleteSettingRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const deleteSettingRequestSchema = z.object({",
"metadata": {
"schemaName": "deleteSettingRequestSchema",
"correspondingType": "DeleteSettingRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 352,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"deleteWorkflowTemplateRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const deleteWorkflowTemplateRequestSchema = z.object({",
"metadata": {
"schemaName": "deleteWorkflowTemplateRequestSchema",
"correspondingType": "DeleteWorkflowTemplateRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 372,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"generateBranchNameRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const generateBranchNameRequestSchema = z.object({",
"metadata": {
"schemaName": "generateBranchNameRequestSchema",
"correspondingType": "GenerateBranchNameRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 382,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"generateWorktreePathRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const generateWorktreePathRequestSchema = z.object({",
"metadata": {
"schemaName": "generateWorktreePathRequestSchema",
"correspondingType": "GenerateWorktreePathRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 394,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"getAllSettingsRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const getAllSettingsRequestSchema = z.object({",
"metadata": {
"schemaName": "getAllSettingsRequestSchema",
"correspondingType": "GetAllSettingsRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 403,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"getCommitsRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const getCommitsRequestSchema = z.object({",
"metadata": {
"schemaName": "getCommitsRequestSchema",
"correspondingType": "GetCommitsRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 415,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"getCurrentBranchRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const getCurrentBranchRequestSchema = z.object({",
"metadata": {
"schemaName": "getCurrentBranchRequestSchema",
"correspondingType": "GetCurrentBranchRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 424,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"getDiffRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const getDiffRequestSchema = z.object({",
"metadata": {
"schemaName": "getDiffRequestSchema",
"correspondingType": "GetDiffRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 435,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"getHeadCommitRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const getHeadCommitRequestSchema = z.object({",
"metadata": {
"schemaName": "getHeadCommitRequestSchema",
"correspondingType": "GetHeadCommitRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 444,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"getSettingOrDefaultRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const getSettingOrDefaultRequestSchema = z.object({",
"metadata": {
"schemaName": "getSettingOrDefaultRequestSchema",
"correspondingType": "GetSettingOrDefaultRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 454,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"getSettingRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const getSettingRequestSchema = z.object({",
"metadata": {
"schemaName": "getSettingRequestSchema",
"correspondingType": "GetSettingRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 463,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"getTaskCommitsRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const getTaskCommitsRequestSchema = z.object({",
"metadata": {
"schemaName": "getTaskCommitsRequestSchema",
"correspondingType": "GetTaskCommitsRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 473,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"getTaskDiffRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const getTaskDiffRequestSchema = z.object({",
"metadata": {
"schemaName": "getTaskDiffRequestSchema",
"correspondingType": "GetTaskDiffRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 482,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"getWorkflowTemplateRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const getWorkflowTemplateRequestSchema = z.object({",
"metadata": {
"schemaName": "getWorkflowTemplateRequestSchema",
"correspondingType": "GetWorkflowTemplateRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 492,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"hasUncommittedChangesRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const hasUncommittedChangesRequestSchema = z.object({",
"metadata": {
"schemaName": "hasUncommittedChangesRequestSchema",
"correspondingType": "HasUncommittedChangesRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 501,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"killProcessRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const killProcessRequestSchema = z.object({",
"metadata": {
"schemaName": "killProcessRequestSchema",
"correspondingType": "KillProcessRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 510,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"listProcessesRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const listProcessesRequestSchema = z.object({",
"metadata": {
"schemaName": "listProcessesRequestSchema",
"correspondingType": "ListProcessesRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 523,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"listWorkflowTemplatesRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const listWorkflowTemplatesRequestSchema = z.object({",
"metadata": {
"schemaName": "listWorkflowTemplatesRequestSchema",
"correspondingType": "ListWorkflowTemplatesRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 533,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"listWorktreesRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const listWorktreesRequestSchema = z.object({",
"metadata": {
"schemaName": "listWorktreesRequestSchema",
"correspondingType": "ListWorktreesRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 542,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"parseWorkflowRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const parseWorkflowRequestSchema = z.object({",
"metadata": {
"schemaName": "parseWorkflowRequestSchema",
"correspondingType": "ParseWorkflowRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 584,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"searchRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const searchRequestSchema = z.object({",
"metadata": {
"schemaName": "searchRequestSchema",
"correspondingType": "SearchRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 605,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"setDefaultExecutorProfileRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const setDefaultExecutorProfileRequestSchema = z.object({",
"metadata": {
"schemaName": "setDefaultExecutorProfileRequestSchema",
"correspondingType": "SetDefaultExecutorProfileRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 623,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"setSettingRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const setSettingRequestSchema = z.object({",
"metadata": {
"schemaName": "setSettingRequestSchema",
"correspondingType": "SetSettingRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 633,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"settingExistsRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const settingExistsRequestSchema = z.object({",
"metadata": {
"schemaName": "settingExistsRequestSchema",
"correspondingType": "SettingExistsRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 659,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"startProcessRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const startProcessRequestSchema = z.object({",
"metadata": {
"schemaName": "startProcessRequestSchema",
"correspondingType": "StartProcessRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 677,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"substituteWorkflowVariablesRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const substituteWorkflowVariablesRequestSchema = z.object({",
"metadata": {
"schemaName": "substituteWorkflowVariablesRequestSchema",
"correspondingType": "SubstituteWorkflowVariablesRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 724,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"updateMessageRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const updateMessageRequestSchema = z.object({",
"metadata": {
"schemaName": "updateMessageRequestSchema",
"correspondingType": "UpdateMessageRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 738,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"updateProcessRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const updateProcessRequestSchema = z.object({",
"metadata": {
"schemaName": "updateProcessRequestSchema",
"correspondingType": "UpdateProcessRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 784,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"updateWorkflowStepRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const updateWorkflowStepRequestSchema = z.object({",
"metadata": {
"schemaName": "updateWorkflowStepRequestSchema",
"correspondingType": "UpdateWorkflowStepRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 796,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"updateWorkflowTemplateRequestSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const updateWorkflowTemplateRequestSchema = z.object({",
"metadata": {
"schemaName": "updateWorkflowTemplateRequestSchema",
"correspondingType": "UpdateWorkflowTemplateRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 810,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"artifactFileSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const artifactFileSchema = z.object({",
"metadata": {
"schemaName": "artifactFileSchema",
"correspondingType": "ArtifactFile"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 822,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"authStatusResponseSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const authStatusResponseSchema = z.object({",
"metadata": {
"schemaName": "authStatusResponseSchema",
"correspondingType": "AuthStatusResponse"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 830,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"branchSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const branchSchema = z.object({",
"metadata": {
"schemaName": "branchSchema",
"correspondingType": "Branch"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 842,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"chatSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const chatSchema = z.object({",
"metadata": {
"schemaName": "chatSchema",
"correspondingType": "Chat"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 869,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"chatSummarySchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const chatSummarySchema = z.object({",
"metadata": {
"schemaName": "chatSummarySchema",
"correspondingType": "ChatSummary"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 885,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"cliInstalledResponseSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const cliInstalledResponseSchema = z.object({",
"metadata": {
"schemaName": "cliInstalledResponseSchema",
"correspondingType": "CliInstalledResponse"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 909,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"commitSummarySchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const commitSummarySchema = z.object({",
"metadata": {
"schemaName": "commitSummarySchema",
"correspondingType": "CommitSummary"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 920,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"dataChangedEventSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const dataChangedEventSchema = z.object({",
"metadata": {
"schemaName": "dataChangedEventSchema",
"correspondingType": "DataChangedEvent"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 933,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"defaultShellResponseSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const defaultShellResponseSchema = z.object({",
"metadata": {
"schemaName": "defaultShellResponseSchema",
"correspondingType": "DefaultShellResponse"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 943,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"deleteAllSettingsResponseSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const deleteAllSettingsResponseSchema = z.object({",
"metadata": {
"schemaName": "deleteAllSettingsResponseSchema",
"correspondingType": "DeleteAllSettingsResponse"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 963,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"executionProcessSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const executionProcessSchema = z.object({",
"metadata": {
"schemaName": "executionProcessSchema",
"correspondingType": "ExecutionProcess"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 984,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"executorProfileSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const executorProfileSchema = z.object({",
"metadata": {
"schemaName": "executorProfileSchema",
"correspondingType": "ExecutorProfile"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 1001,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"executorProfileSummarySchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const executorProfileSummarySchema = z.object({",
"metadata": {
"schemaName": "executorProfileSummarySchema",
"correspondingType": "ExecutorProfileSummary"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 1029,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"fileDiffSummarySchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const fileDiffSummarySchema = z.object({",
"metadata": {
"schemaName": "fileDiffSummarySchema",
"correspondingType": "FileDiffSummary"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 1040,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"gitStatusSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const gitStatusSchema = z.object({",
"metadata": {
"schemaName": "gitStatusSchema",
"correspondingType": "GitStatus"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 1052,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"gitStatusFileSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const gitStatusFileSchema = z.object({",
"metadata": {
"schemaName": "gitStatusFileSchema",
"correspondingType": "GitStatusFile"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 1062,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"messageSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const messageSchema = z.object({",
"metadata": {
"schemaName": "messageSchema",
"correspondingType": "Message"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 1079,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"messageSummarySchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const messageSummarySchema = z.object({",
"metadata": {
"schemaName": "messageSummarySchema",
"correspondingType": "MessageSummary"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 1093,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"processOutputEventSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const processOutputEventSchema = z.object({",
"metadata": {
"schemaName": "processOutputEventSchema",
"correspondingType": "ProcessOutputEvent"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 1104,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"processStatusEventSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const processStatusEventSchema = z.object({",
"metadata": {
"schemaName": "processStatusEventSchema",
"correspondingType": "ProcessStatusEvent"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 1114,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"processSummarySchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const processSummarySchema = z.object({",
"metadata": {
"schemaName": "processSummarySchema",
"correspondingType": "ProcessSummary"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 1130,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"projectSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const projectSchema = z.object({",
"metadata": {
"schemaName": "projectSchema",
"correspondingType": "Project"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 1153,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"projectSummarySchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const projectSummarySchema = z.object({",
"metadata": {
"schemaName": "projectSummarySchema",
"correspondingType": "ProjectSummary"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 1176,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"searchResultSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const searchResultSchema = z.object({",
"metadata": {
"schemaName": "searchResultSchema",
"correspondingType": "SearchResult"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 1189,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"settingSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const settingSchema = z.object({",
"metadata": {
"schemaName": "settingSchema",
"correspondingType": "SettingRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 1199,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"settingExistsResponseSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const settingExistsResponseSchema = z.object({",
"metadata": {
"schemaName": "settingExistsResponseSchema",
"correspondingType": "SettingExistsResponseRequest"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 1207,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"taskSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const taskSchema = z.object({",
"metadata": {
"schemaName": "taskSchema",
"correspondingType": "Task"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 1228,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"taskSummarySchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const taskSummarySchema = z.object({",
"metadata": {
"schemaName": "taskSummarySchema",
"correspondingType": "TaskSummary"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 1243,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"taskWithChatsSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const taskWithChatsSchema = z.object({",
"metadata": {
"schemaName": "taskWithChatsSchema",
"correspondingType": "TaskWithChats"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 1252,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"workflowContextSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const workflowContextSchema = z.object({",
"metadata": {
"schemaName": "workflowContextSchema",
"correspondingType": "WorkflowContext"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 1292,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"workflowTemplateSummarySchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const workflowTemplateSummarySchema = z.object({",
"metadata": {
"schemaName": "workflowTemplateSummarySchema",
"correspondingType": "WorkflowTemplateSummary"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 1304,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"worktreeSchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const worktreeSchema = z.object({",
"metadata": {
"schemaName": "worktreeSchema",
"correspondingType": "Worktree"
}
},
{
"file": "packages/validation/schemas-generated.ts",
"line": 1316,
"column": 1,
"rule": "zod/unused-schema",
"message": "Schema \"worktreeSummarySchema\" is defined but never used in validation",
"severity": "warning",
"suggestion": "Either use this schema in validation logic or remove it if unnecessary",
"snippet": "export const worktreeSummarySchema = z.object({",
"metadata": {
"schemaName": "worktreeSummarySchema",
"correspondingType": "WorktreeSummary"
}
}
],
"executionTimeMs": 396,
"metadata": {
"totalTypesUsedInQueries": 41,
"totalSchemasDefinedInValidation": 138,
"inputTypes": 21,
"inputTypesWithSchemas": 21,
"inputCoveragePercent": 100,
"missingInputSchemas": 0,
"missingOutputSchemas": 0,
"unusedSchemas": 81,
"config": "zod-coverage",
"scope": [
"packages/generated",
"packages/validation",
"packages/queries"
]
}
},
{
"validator": "routes",
"timestamp": "2026-01-03T04:28:11.448Z",
"status": "pass",
"errorCount": 0,
"warningCount": 0,
"infoCount": 0,
"violations": [],
"executionTimeMs": 123,
"metadata": {
"filesChecked": 16,
"rulesChecked": 8,
"config": "routes",
"scope": "src/routes",
"routeStats": {
"totalLines": 1680,
"avgLinesPerRoute": 105,
"maxLines": 224,
"maxLinesFile": "src/routes/_app/index.tsx",
"oversizedRoutes": 0,
"inlineComponents": 0,
"styledUsages": 0,
"jsxLogicUsages": 0
}
}
},
{
"validator": "storybook",
"timestamp": "2026-01-03T04:28:12.215Z",
"status": "pass",
"errorCount": 0,
"warningCount": 0,
"infoCount": 0,
"violations": [],
"executionTimeMs": 54,
"metadata": {
"componentsChecked": 83,
"storiesFound": 84,
"coveragePercent": 100,
"componentsMissingStories": 0,
"orphanStories": 0,
"rulesChecked": 2,
"config": "storybook",
"scope": "packages/ui"
}
},
{
"validator": "test-coverage",
"timestamp": "2026-01-03T04:28:12.892Z",
"status": "warn",
"errorCount": 0,
"warningCount": 1,
"infoCount": 0,
"violations": [
{
"file": "coverage/coverage-summary.json",
"rule": "coverage/below-threshold",
"message": "Coverage report not found. Run 'pnpm test --coverage' to generate coverage data.",
"severity": "warning",
"suggestion": "Run \"pnpm test --coverage\" to generate coverage report",
"metadata": {
"coveragePath": "/home/runner/work/openflow/openflow/coverage/coverage-summary.json",
"expected": "coverage/coverage-summary.json"
}
}
],
"executionTimeMs": 2,
"metadata": {
"coverageFileExists": false,
"coverageFilePath": "coverage/coverage-summary.json",
"overallCoverage": 0,
"overallThreshold": 30,
"packageCoverages": [],
"thresholds": {
"hooks": 40,
"queries": 60,
"validation": 80,
"overall": 30
},
"rulesChecked": 1,
"config": "test-coverage"
}
},
{
"validator": "rust-services",
"timestamp": "2026-01-03T04:28:13.619Z",
"status": "pass",
"errorCount": 0,
"warningCount": 0,
"infoCount": 0,
"violations": [],
"executionTimeMs": 22,
"metadata": {
"commandCount": 108,
"serviceCount": 0,
"methodCount": 0,
"commandFilesScanned": 14,
"serviceFilesScanned": 0,
"config": "rust-services",
"rules": [
"businessInCommand",
"serviceNotResult",
"commandComplexity"
],
"thresholds": {
"maxCommandLines": 20
},
"scope": {
"commands": "src-tauri/src/commands",
"services": "src-tauri/src/services"
}
}
},
{
"validator": "primitives",
"timestamp": "2026-01-03T04:28:15.544Z",
"status": "pass",
"errorCount": 0,
"warningCount": 0,
"infoCount": 0,
"violations": [],
"executionTimeMs": 612,
"metadata": {
"filesChecked": 84,
"rulesChecked": 1,
... (truncated, see artifacts for full report)Generated by OpenFlow Validation Suite
Code Review: End-to-End Audit and FixesThis is a comprehensive PR that fixes HTTP/Web mode functionality across the stack. Overall, the changes are well-structured and follow the project's architecture patterns. Below is my detailed feedback. ✅ Strengths1. Security: Path Traversal Prevention (artifact.rs:172-208) 2. Contract-First Development 3. Query Parameter Casing Alignment 4. PTY Writer Fix (pty.rs:146-279) 5. CSS Selector Escaping (Dropdown.tsx) 6. Toast Deduplication
|
| Aspect | Assessment |
|---|---|
| Code Quality | ✅ Good - follows patterns |
| Security | ✅ Path traversal protection implemented |
| Performance | ✅ PTY writer fix improves efficiency |
| Test Coverage | |
| Best Practices |
Verdict: This PR is ready to merge with the understanding that:
- Toast deduplication duplication is acceptable for now (both implementations work)
- Artifact service tests can be added in a follow-up PR
- The binary screenshot file should be removed or gitignored
Great work on this comprehensive audit and fix! 🎉
🤖 Generated with Claude Code
Change `.and_then(|x| Some(y))` to `.map(|x| y)` as recommended by Clippy for more idiomatic Rust code. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Changed PTY output streaming from line-based to chunk-based reading for better real-time output delivery - Created separate WsBroadcaster for HTTP server with stored tokio::runtime::Handle to fix async context issues - Added retry loop (20 attempts, 100ms delay) when waiting for process exit to ensure status is always broadcast - Fixed UI staying stuck in "responding" state by guaranteeing process status events are always sent on completion - Applied cargo fmt to entire codebase These fixes enable: - Terminal output streaming in HTTP/web mode - Proper Claude Code response capture - Follow-up messages work correctly after initial response 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes a comprehensive end-to-end QA audit of the OpenFlow application and fixes all critical HTTP endpoint issues, making the web UI fully functional. The audit covered both Tauri desktop app with embedded server and web frontend modes.
Final Status: ✅ MVP READY - Core functionality works in both Tauri and Web modes. All CRITICAL and HIGH priority bugs fixed.
Changes
Backend API Fixes
list_tasks,list_standalone_chats,list_messagesendpoints (query param casing mismatch)spawn_terminalendpoint (request body handling)get_taskandget_chatresponse types (return full entities with relations)q→query)Frontend Transport Alignment
request: input)id: processId)UI/UX Navigation Fixes
State Management & Notifications
Critical Bug Fixes
:r45:invalid CSS selector)Test Plan
pnpm test) - 8614 tests passednpx tsc --noEmit)pnpm lint) - warnings only in storybook non-null assertionspnpm validate:all) - 12 passed, 3 warnedcargo test) - 12 tests passedpnpm dev)Features Verified Working
Known Limitations (documented with workarounds)
Related Issues
This PR addresses the comprehensive QA audit task for end-to-end application testing and fixes.
Screenshots
N/A - Testing performed via Playwright MCP browser automation with accessibility snapshots.
🤖 Generated with Claude Code