fix(ci): use simple release-type with workspace-version extra-file - #100
Merged
Conversation
…ersion The `rust` release-type walks every workspace member's Cargo.toml and rejects `version.workspace = true` because it can't read a literal version there. All Plumb crates inherit the workspace version by design. Switch to release-type `simple` (single-package, non-language-aware) and use an `extra-files` entry to rewrite the `[workspace.package] version` in the root Cargo.toml. Workspace inheritance cascades the new version to every member automatically. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #99. Removing the
cargo-workspaceplugin wasn't enough — therustrelease-type itself walks each member's Cargo.toml and rejectsversion.workspace = truewithvalue at path package.version is not tagged.Switch the root package to
release-type: simple(language-agnostic) and add anextra-filesentry that rewrites the single[workspace.package] version = "x.y.z"line in the root Cargo.toml. Workspace inheritance cascades that version to every member crate automatically — release-please only ever has to touch one file.Test plan
release-please.ymlafter merge and confirm it either opens a release PR or reports no releasable changes.🤖 Generated with Claude Code