Skip to content

docs: ship the full brand kit and polish the book theme - #307

Merged
aram-devdocs merged 1 commit into
mainfrom
feat/brand-assets-and-polish
Jun 19, 2026
Merged

docs: ship the full brand kit and polish the book theme#307
aram-devdocs merged 1 commit into
mainfrom
feat/brand-assets-and-polish

Conversation

@aram-devdocs

Copy link
Copy Markdown
Owner

Context

Follow-up to the brand work: put every asset in the repo so it's public and viewable, fix the favicon situation, and make the GitHub/docs surfaces feel finished — using the blueprint-grid aesthetic from the brand board (the white mark on brand-blue with a construction grid), not a flat logo.

What changed

  • Full kit checked inassets/brand/{svg,png,mockups,source}/: all 14 vectors + rasters, the brand-board renders (incl. the construction-grid mark Plumb-11.jpg and the signage mockup), and the editable Plumb.ai/.eps/.pdf. BRAND.md is now a viewable gallery + manifest.
  • Blueprint-grid social card — new assets/brand/plumb-og.{svg,png} (white lockup on the brand-blue grid + a 45° set-square construction line) and a square plumb-social-square.*. The docs Open Graph card now uses the gridded version.
  • Book theme matches the brand — a theme-aware lockup hero on the landing page (light/dark swap), the app-icon mark beside the menu title, and the blue app-icon favicon (mdBook injects it).
  • README leads with the gridded brand banner.

On the favicon / "white logo on GitHub"

The docs site only redeploys on release: published, and a GITHUB_TOKEN-cut release doesn't fire that event — so the live site still shows the pre-brand favicon. After this merges I'll dispatch pages.yml to deploy. For the repo social preview (Settings → General → Social preview), upload assets/brand/plumb-og.png — GitHub's repo card can't be set via API.

Closes the favicon polish; mdbook build + cargo doc verified locally. (npm re-publish tracked in #306.)

🤖 Generated with Claude Code

Puts every brand asset in the repo so they are public and viewable, and
makes the docs site and README feel finished.

- assets/brand/: the complete export is now checked in — svg/ + png/
  (all 14 vectors/rasters), mockups/ (brand-board renders incl. the
  construction-grid mark and the signage mockup), and source/
  (Plumb.ai/.eps/.pdf). BRAND.md is now a viewable gallery + manifest.
- New blueprint-grid social card (assets/brand/plumb-og.{svg,png}) and a
  square gridded mark (plumb-social-square.*) — the white logo now sits
  on the brand-blue construction grid instead of a flat field. The docs
  Open Graph card uses it.
- docs book theme matches the brand: a theme-aware lockup hero on the
  landing page (light/dark swap), the app-icon mark beside the menu
  title, and the favicon remains the blue app icon (mdBook injects it;
  it shows once the Pages site redeploys).
- README leads with the gridded brand banner.

The docs site only redeploys on release: published, and a
GITHUB_TOKEN-cut release does not fire that event — so the live
favicon/theme lag until `pages.yml` is dispatched.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@aram-devdocs
aram-devdocs merged commit 59d1046 into main Jun 19, 2026
27 of 33 checks passed
@aram-devdocs
aram-devdocs deleted the feat/brand-assets-and-polish branch June 19, 2026 15:04
@github-actions

Copy link
Copy Markdown
Contributor

I have enough information to write the review. This is a pure docs/brand PR — no Rust source changes at all.


PR #307 — docs: ship the full brand kit and polish the book theme

Crates touched: docs only (docs/src/, docs/theme/, assets/brand/, README.md).
No crates in crates/ were modified.


1. Determinism invariants

N/A — no Rust code.

2. Workspace layering

N/A — no Rust code.

3. Error handling

N/A — no Rust code.

4. Test coverage

N/A — no public API added.

5. Documentation quality

docs/src/introduction.md:2 — The hero div uses the deprecated HTML align="center" attribute. The .plumb-hero CSS block already owns the layout; the attribute is redundant and invalid HTML5. Fix: either remove the attribute and add text-align: center to .plumb-hero in custom.css, or just remove align — the containing block is full-width and the max-width: min(300px, 70%) with the img display default will left-align the image, so text-align: center on .plumb-hero is the right fix.

assets/brand/plumb-og.svg (last line) / assets/brand/plumb-social-square.svg (last line) — Both SVGs are missing a trailing newline (\ No newline at end of file in the diff). Minor, but will generate spurious ~ hunks in every future diff touching these files.

Humanizer checkdocs/src/** was touched (introduction.md, three SVGs added). Per documentation.md, the humanizer skill must run before merge. The only prose change is one sentence in assets/brand/BRAND.md (not docs/src/), which is clean ("doubles as a nod to…" — no AI-tell phrases). The docs/src/introduction.md addition is pure HTML markup; humanizer would trivially pass. Still, the formal gate should be checked off.

README.md — The <picture> / prefers-color-scheme dark-mode toggle was removed in favour of a single <img> pointing at the blue OG card. On GitHub dark mode the blue OG card renders fine, so this is intentional and not a regression. Noted, not flagged.


Punch list

Location Issue Class
docs/src/introduction.md:2 <div align="center"> — deprecated; move centering to .plumb-hero { text-align: center } in custom.css Warning
assets/brand/plumb-og.svg (EOF) Missing trailing newline Nit
assets/brand/plumb-social-square.svg (EOF) Missing trailing newline Nit
Workflow Humanizer gate on docs/src/** must be formally signed off Process

No blockers. The deprecated attribute and missing newlines are the only substantive findings.

Verdict: APPROVE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant