fix(ci): drop cargo-workspace plugin from release-please - #99
Merged
Conversation
The cargo-workspace plugin fails on member crates that use `version.workspace = true` because it reads each member Cargo.toml directly and can't resolve workspace inheritance. Plumb is configured as a single release-please package rooted at "." with a single version in .release-please-manifest.json; the plugin was doing nothing useful and only blocking the workflow. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The cargo-workspace plugin in release-please fails on member crates that use
version.workspace = truebecause it reads each Cargo.toml directly and doesn't resolve workspace inheritance. Result: every release-please run exits withpackage manifest at crates/plumb-core/Cargo.toml has an invalid [package.version].Plumb is configured as a single release-please package rooted at "." with a single version tracked in .release-please-manifest.json, so the plugin was doing nothing useful — only blocking the workflow.
Test plan
gh workflow run release-please.ymland confirm it either opens a release PR or reports "no releasable changes" (both are success outcomes).