Harden release CI: require released commit on main#8
Merged
Conversation
… sync release spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Medium (release-safety)
release.ymlpreviously only checked the release tag (minusv) againstmix.exs@version, then ranmix hex.publish --yes. A GitHub Release on any off-mainline commit that still read the target@versionwould pass and publish. The plan had a manual SHA guard, but the workflow is the irreversible boundary, so the check belongs there.This adds a second fail-hard gate in the workflow:
actions/checkoutnow usesfetch-depth: 0(full history).git fetch --no-tags origin mainthengit merge-base --is-ancestor "$GITHUB_SHA" origin/main— aborts the publish if the released commit is not onmain.Verified locally: a commit on
mainpasses; an off-mainline commit (the squash-mergedrevive-and-modernizetip) aborts.Low (doc drift)
Synced
2026-06-02-hex-release-ci-design.mdto the actual workflow:actions/checkout@v6, toolchain from.tool-versions(strict), and the new on-main gate.actionlint clean.