Skip to content

Switch algorithme for auto-generated TLS certificates from RSA to ECDSA #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ewoutp merged 2 commits into from
Apr 26, 2018
Merged

Switch algorithme for auto-generated TLS certificates from RSA to ECDSA #152

ewoutp merged 2 commits into from
Apr 26, 2018

Conversation

@ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Apr 26, 2018 •
edited
Loading

This PR replaces the custom code for generating a certificate with go-certificates.

Sample of generated keyfile:

-----BEGIN CERTIFICATE-----
MIIBeTCCASCgAwIBAgIQb8S89uzuneBt0L0+60T8tjAKBggqhkjOPQQDAjATMREw
DwYDVQQKEwhBcmFuZ29EQjAeFw0xODA0MjYwODMzMTRaFw0xOTA0MjYwODMzMTRa
MBMxETAPBgNVBAoTCEFyYW5nb0RCMFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAE
pmkoYRYuNqHOxFzAyO0tgRzEc6apmr+HPekXN/i4eOdcW0OO+j5g/UKOgZYR/y8v
gufZmwqU7EnJ4VsuG6JO9KNWMFQwDgYDVR0PAQH/BAQDAgWgMBkGA1UdJQQSMBAG
BFUdJQAGCCsGAQUFBwMBMAwGA1UdEwEB/wQCMAAwGQYDVR0RBBIwEIIOYXJhbmdv
ZC5zZXJ2ZXIwCgYIKoZIzj0EAwIDRwAwRAIgHy4U33B1GZ3lm5MJYET05gPu9/rp
+ZflFQs/W/IBj1MCIER+uyZLv4apuVsMAG5P4E2O1+EoCBKErBJx9uNPCXdj
-----END CERTIFICATE-----
-----BEGIN EC PRIVATE KEY-----
MHcCAQEEINuY8i35X5XXdYg2LGOrSgWpy03+s0j3Sqzk8xQRhmoaoAoGCCqGSM49
AwEHoUQDQgAEpmkoYRYuNqHOxFzAyO0tgRzEc6apmr+HPekXN/i4eOdcW0OO+j5g
/UKOgZYR/y8vgufZmwqU7EnJ4VsuG6JO9A==
-----END EC PRIVATE KEY-----

@ewoutp ewoutp requested a review from neunhoef April 26, 2018 08:37
neunhoef
neunhoef approved these changes Apr 26, 2018
View reviewed changes
Copy link
Contributor

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewoutp ewoutp merged commit 436a406 into master Apr 26, 2018
@ewoutp ewoutp deleted the ssl-auto-keyfile-with-curves branch April 26, 2018 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@neunhoef neunhoef neunhoef approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

9 Review Required 9 Waiting for Jenkins

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ewoutp @neunhoef