Documented changed upgrade procedure design #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neunhoef
approved these changes
Jul 16, 2018
Contributor
neunhoef
left a comment
neunhoef
left a comment
There was a problem hiding this comment.
LGTM. See two (related) suggestions.
docs/upgrade_spec.md
Outdated
| upgrade failure, or `false` otherwise. | ||
| - `reason` a string that describes the state of the upgrade plan in a | ||
| human readable form. | ||
| - `servers_upgraded` an integer containing the number of servers that have |
Contributor
There was a problem hiding this comment.
Why not put the list of upgraded instances in here?
docs/upgrade_spec.md
Outdated
| human readable form. | ||
| - `servers_upgraded` an integer containing the number of servers that have | ||
| been upgraded. | ||
| - `servers_remaining` an integer containing the number of servers that have |
Contributor
There was a problem hiding this comment.
Same here, sounds like useful information to me.
Contributor
|
Oh, I forgot something: The |
Contributor
|
Likewise, we need to put the restarting of the starters itself in somewhere. |
1 similar comment
Contributor
|
Likewise, we need to put the restarting of the starters itself in somewhere. |
Contributor
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR documents the changed upgrade procedure needed for 3.4 resulting in an automatic upgrade of all servers of a starter cluster with agents, then dbservers, then coordinators.