Copy installation files on startup #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neunhoef
suggested changes
Sep 26, 2018
Contributor
neunhoef
left a comment
neunhoef
left a comment
There was a problem hiding this comment.
This will not work, since then the starter can no longer be used with old versions. We need to make this dependent on the version found.
ewoutp
reviewed
Sep 27, 2018
service/arangod_config_builder.go
Outdated
| optionPair{"--log.force-direct", "false"}, | ||
| ) | ||
|
|
||
| if !config.RunningInDocker && features.CopyInstallationFiles() { |
Contributor
There was a problem hiding this comment.
Is this needed for all server types in all deployment types?
Contributor
Author
There was a problem hiding this comment.
Good point, will adjust
Contributor
Author
There was a problem hiding this comment.
ok technically its a bit complicated: on 3.4 only single-servers / coordinators need it, but on 3.3.17 all servers will need it. Since 3.4 will ignore the option on dbservers/ agents I think we can just leave it like that
maierlars
approved these changes
Oct 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for new option https://github.com/arangodb/arangodb/pull/6615/files