Batch driver performance fix #31
Merged
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-zajic
force-pushed
the
batch-perf
branch
from
64074eb to
e555b87
Compare
a-brandt
pushed a commit
that referenced
this pull request
Feb 12, 2016
Batch driver performance fix
Collaborator
|
@jan-zajic thanks a lot for your contribution. We are using the Apache 2 license for the source. You are also using a Apache CLA for contribution. Can you please sign, scan and email https://www.arangodb.com/documents/cla.pdf to cla (at) arangodb.com Again thanks a lot |
Contributor
|
@jan-zajic we really liked to accept your contribution. Is it possible for you to sign a CLA as @fceller questioned? |
Contributor
Author
|
@dothebart I sent it to email hackers (at) arangodb.com and cla (at) arangodb.com with subject "PR #31". |
Collaborator
|
@jan-zajic thanks a lot and thank you again for you contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fix performance issue in batch driver. I try to run several thousand operations in one batch request, but there will never be send to server before my fix. It's because String concatenation within loop. After fix, i run very large batch queries without problem.
Where you're concatenating in a loop - that's usually when the compiler can't substitute StringBuilder by itself.