[3.10] Move transitive dependencies #16857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 23, 2022 11:51
ghost
added
9 Waiting for Jenkins
3 JS API
ghost
requested review from
KVS85,
Zyqsempai,
adityamukho,
hkernbach and
mpoeter
ghost
self-assigned this
hkernbach
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
This is a backport of #16856 for 3.10.
This PR moves the transitive dependencies
media-typerandis-wslinto the dependencies depending on them (type-isandnode-netstatrespectively) to make them unavailable via accidental direct imports. Additionally the moduleparse-prometheus-text-formatis marked as adevDependencyinpackage.jsonto allow filtering it out during release in the future.This PR fixes the oversight in #16542 of not removing
media-typerfromnode_modulesas indicated in the CHANGELOG due to the module still being present as a transitive dependency.Checklist
Related Information