keep jwt secret when using arango.reconnect(...)
#18999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 15, 2023
dothebart
approved these changes
May 16, 2023
Contributor
dothebart
left a comment
dothebart
left a comment
There was a problem hiding this comment.
LGTM.
Does this work properly with the connection cache since the JWT is used to identify a connection on the list as well?
KVS85
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Backport of #18997
Keep original JWT secret in arangosh when using
arango.reconnect(...)when not overriding the JWT.This restores behavior that used to work in 3.9.
Checklist
arango.reconnect(...)#19000Related Information