Fix flakiness of aql-index-cache test
#21597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dothebart
approved these changes
Feb 6, 2025
KVS85
approved these changes
Feb 6, 2025
jbajic
force-pushed
the
increase-number-of-tries
branch
from
36541be to
606f0f3
Compare
jbajic
changed the title
aql-index-cache test
KVS85
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Tries to address the issue of a query having no cache hits after by increasing the maximum number of tries. The CI reported the assertion failure on cache hits, which was 0. The tests in question were:
testPointLookupAndUpdate_nonUniqueon CItestPointLookupAndUpdate_uniqueon CItestPointLookupAndTruncate_nonUniquelocallyIncreasing the number of
maxTriessolves the problem of local execution, but it appears on CI afterward. The assumed issue is that the caching does not happen since, in the test, the system is overwhelmed and does not manage to cache queries, therefore, dropping the bucket's size reduces the flakiness.Checklist
Related Information
(Please reference tickets / specification / other PRs etc)