Skip to content

[DOC-604] Download always latest oasisctl tag in Dockerfile #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 18, 2023
Merged

[DOC-604] Download always latest oasisctl tag in Dockerfile #288

merged 9 commits into from
Oct 18, 2023

Conversation

@dandimeo
Copy link
Contributor

@dandimeo dandimeo commented Oct 12, 2023

Description

Upstream PRs

  • 3.10:
  • 3.11:
  • 3.12:

@dandimeo dandimeo requested review from Simran-B and nerpaula October 12, 2023 13:54
@arangodb-docs-automation
Copy link
Contributor

arangodb-docs-automation bot commented Oct 12, 2023

Deploy Preview Available Via
https://deploy-preview-288--docs-hugo.netlify.app

Simran-B
Simran-B requested changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@Simran-B Simran-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still requires that we rebuild (and publish?) the image. The oasisctl generator should instead fetch the latest release and download the files so that we always get the latest oasisctl in the scheduled workflow without rebuilding the image.

@dandimeo
Copy link
Contributor Author

dandimeo commented Oct 16, 2023

This still requires that we rebuild (and publish?) the image. The oasisctl generator should instead fetch the latest release and download the files so that we always get the latest oasisctl in the scheduled workflow without rebuilding the image.

Oasisctl latest binary download is now part of the toolchain script so it will always run when "oasisctl" is part of generators.

https://app.circleci.com/pipelines/github/arangodb/docs-hugo/2737/workflows/7a78e746-966f-4320-9547-ac0b0ad7b324/jobs/6968

Quite basic implementation for the moment. A future better implementation could do some version checking to avoid duplicating the download step for each docs version

@dandimeo dandimeo requested a review from Simran-B October 16, 2023 14:17
Simran-B
Simran-B reviewed Oct 17, 2023
View reviewed changes
@nerpaula nerpaula requested a review from Simran-B October 18, 2023 08:34
Simran-B
Simran-B approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@Simran-B Simran-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only logging should be slightly adjusted

@nerpaula nerpaula merged commit 39ff057 into main Oct 18, 2023
@nerpaula nerpaula deleted the DOC-604 branch October 18, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Simran-B Simran-B Simran-B approved these changes

@nerpaula nerpaula Awaiting requested review from nerpaula

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dandimeo @Simran-B @nerpaula