Skip to content

Conversation

@nerpaula
Copy link
Contributor

@nerpaula nerpaula commented Oct 31, 2023

Description

Preview: https://deploy-preview-328--docs-hugo.netlify.app/stable/arangograph/data-loader/

TO DO:

  • apply to all versions
  • revise screenshots
  • add Import description once finalized
  • add more info about the parsing errors and import helper once finalized
  • add end-to-end example

@arangodb-docs-automation
Copy link
Contributor

Deploy Preview Available Via
https://deploy-preview-328--docs-hugo.netlify.app

@cla-bot cla-bot bot added the cla-signed label Oct 31, 2023
@nerpaula nerpaula self-assigned this Oct 31, 2023
@nerpaula nerpaula marked this pull request as ready for review November 20, 2023 02:57
@nerpaula nerpaula requested review from a team, ansoboleva, mattcarabine and shd8 November 20, 2023 02:57
Copy link
Contributor

@ansoboleva ansoboleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Simran-B
Copy link
Contributor

Simran-B commented Nov 20, 2023

With the tabs, it takes 3 clicks to read all 4 sentences. What purpose does this serve?

@nerpaula
Copy link
Contributor Author

With the tabs, it takes 3 clicks to read all 4 sentences. What purpose that this serve?

@Simran-B IMO it's not all about "how many clicks it takes", this applies mostly to actions you do in the web interface. But when it comes to docs, sometimes one does need a bit of visual mix and only scrolling may feel dull.

@Simran-B
Copy link
Contributor

An ordered list can also add visual interest without making the content inaccessible to in-page search:

image

@Simran-B
Copy link
Contributor

Maybe noteworthy: the data loader supports ; as a delimiter and values with line breaks in them if wrapped in quotes.
All values are imported as strings, however.

"File headers" is a bit of an odd choice for a label as it isn't clear that this is for selecting fields to be imported. There should be an option to tick all boxes IMO (perhaps excluding the ones already used for _key, _from, and _to). The example values column could use a label to explain what this is.

@nerpaula nerpaula merged commit 812eaa0 into main Nov 22, 2023
@nerpaula nerpaula deleted the dataloader branch November 22, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants