-
Notifications
You must be signed in to change notification settings - Fork 81
Feature/add mis endpoints in monitoring #701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds several monitoring and administrative endpoints to the ArangoDB Go driver, enabling better observability and log management capabilities. The implementation includes comprehensive testing for all new endpoints and proper integration with existing client patterns.
- Adds 6 new admin/monitoring endpoints for log management, structured logging, API call tracking, and metrics collection
- Implements proper query parameter handling and validation for complex log filtering options
- Provides comprehensive test coverage for all new endpoints with version compatibility checks
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| v2/arangodb/client_admin.go | Defines interfaces and data structures for new monitoring endpoints |
| v2/arangodb/client_admin_log_impl.go | Implements the actual HTTP client methods for all new endpoints |
| v2/tests/admin_log_test.go | Adds comprehensive test coverage for all new endpoints |
| Makefile | Updates default ArangoDB Docker image to enterprise edition |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
3469011 to
f2d0664
Compare
This PR includes the following Monitoring - related endpoints: