Move irrelevant logs to TRACE level #1035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
informalict
approved these changes
Jun 28, 2022
Contributor
informalict
left a comment
informalict
left a comment
There was a problem hiding this comment.
LGTM, small suggestion
|
|
||
| defer func() { | ||
| d.log.Info("Reconciliation loop took %s", time.Since(t)) | ||
| d.log.Trace("Reconciliation loop took %s", time.Since(t)) |
Contributor
There was a problem hiding this comment.
maybe we should have here INFO or WARNING when time.Since(t) is higher than some value (e.g. 5 seconds).
Then we would know that the reconciliation loop took too long and should be investigated. e.g.:
if time.Since(t) > time.Second * 10 {
d.log.Info("Reconciliation loop took too long %s", time.Since(t))
} else {
d.log.Trace("Reconciliation loop took %s", time.Since(t))
}
| defer cancelReconciliation() | ||
| defer func() { | ||
| d.log.Info("Inspect loop took %s", time.Since(start)) | ||
| d.log.Trace("Inspect loop took %s", time.Since(start)) |
Contributor
There was a problem hiding this comment.
the same here as below comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current log output when
log.level=trace: