-
Notifications
You must be signed in to change notification settings - Fork 72
[Feature] [License] Activation CLI #1972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a CLI activation feature for license management, introducing new commands for activating, generating, and managing licenses and registry credentials.
- Added license management commands (
activate,generate,secret) to the platform CLI - Implemented
time.Durationsupport for CLI flags - Added registry override functionality for Helm packages
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/util/cli/flag.go | Added time.Duration flag type support and refactored type checking using reflection |
| pkg/util/arangod/request.go | New HTTP request utility for ArangoDB API communication |
| pkg/platform/runner.go | Added license-related flags to runner validation |
| pkg/platform/package_registry.go | New command to point package images to a different registry |
| pkg/platform/package.go | Registered the new registry subcommand |
| pkg/platform/pack/registry.go | Implementation of registry override logic for Helm packages |
| pkg/platform/pack/proto.go | Made image fields optional and added ProtoValues type |
| pkg/platform/pack/import.go | Refactored to use shared ProtoValues type |
| pkg/platform/pack/export.go | Removed Kind field clearing from image export |
| pkg/platform/manager.go | Helper function to create license manager client from flags |
| pkg/platform/license_secret.go | Command to create Kubernetes secret with registry credentials |
| pkg/platform/license_generate.go | Command to generate licenses for deployments |
| pkg/platform/license_activate.go | Command to activate licenses on ArangoDB endpoints |
| pkg/platform/license.go | Root license command with subcommands |
| pkg/platform/installer.go | Registered license command in installer |
| pkg/platform/flags.go | Added flags for license manager configuration and ArangoDB endpoint |
| pkg/platform/arangodb.go | Helper to create ArangoDB connection from flags |
| pkg/license/manager/stage.go | Stage parsing and registry domain mapping |
| pkg/license/manager/registry.go | Registry authentication structure for Docker config |
| pkg/license/manager/inventory.go | Placeholder inventory structure |
| pkg/license/manager/client.go | HTTP client for license manager API |
| pkg/deployment/client/id.go | Added ClusterID retrieval method |
| pkg/deployment/client/client.go | Added ClusterID method to client interface |
| internal/readme_cli.go | Added documentation generation for new license commands |
| internal/docs_test.go | Refactored write function and added writef for formatted writes |
| docs/cli/arangodb_operator_platform.md | Documentation for new license CLI commands |
| CHANGELOG.md | Added changelog entry for license activation feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
9a183b9 to
e2e972c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 27 out of 27 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
8ab0268 to
29bab42
Compare
29bab42 to
d5616a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 25 out of 25 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.