[Bugfix] [Platform] Fix Container Resource Adjustments #1996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwierzbo
approved these changes
Nov 26, 2025
Copilot finished reviewing on behalf of
ajanikow
November 26, 2025 10:39
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in container resource management where downscaling of resources was not possible. Previously, the code used UpscaleContainerResourceList which only allowed increasing resource values, preventing legitimate downscaling operations. The fix replaces this with MergeContainerResource which properly handles both upscaling and downscaling scenarios.
- Replaced
UpscaleContainerResourceListwithMergeContainerResourcein the Apply method to enable bidirectional resource adjustments - Added a "Downscale" test case to verify that resources can be properly reduced from 8Mi to 1Mi
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/apis/scheduler/v1beta1/container/resources/resources.go | Updated Apply method to use MergeContainerResource instead of UpscaleContainerResourceList, enabling proper resource downscaling |
| pkg/apis/scheduler/v1beta1/container/resources/resources_test.go | Added Downscale test case to verify that container resources can be reduced from higher to lower values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.